Last modified: 2012-04-20 14:09:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37884, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 35884 - h1, h2, h3, h4, h5, h6 { width: auto; } in skins/common/commonElements.css is unnecessary


Summary:	h1, h2, h3, h4, h5, h6 { width: auto; } in skins/common/commonElements.css is...

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Interface (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized enhancement (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-04-11 11:26 UTC by Fomafix
Modified:	2012-04-20 14:09 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Fomafix 2012-04-11 11:26:40 UTC

In skins/common/commonElements.css the

 h1, h2, h3, h4, h5, h6 { width: auto; }

seams unnecessary, because auto is the initial value for width:

 http://www.w3.org/TR/CSS2/visudet.html#propdef-width

In https://svn.wikimedia.org/viewvc/mediawiki?view=revision&revision=95837
the width:auto was copied from skins/vector/screen.css
but skins/monobook/main.css hadn't width:auto.

skins/vector/screen.css had the width:auto from the first revision:
https://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/vector/screen.css?revision=51086&view=markup

Here is an unanswered question for the reason for width: auto:
https://bugzilla.wikimedia.org/show_bug.cgi?id=1629#c55

Please mark this bug as INVALID when there is a reason for width: auto.

Comment 1 Antoine "hashar" Musso (WMF) 2012-04-20 14:07:43 UTC

Was introduced by the Vector skin ( b74f7169675c3971db0 ).

Comment 2 Antoine "hashar" Musso (WMF) 2012-04-20 14:09:44 UTC

Patch sent  https://gerrit.wikimedia.org/r/5430

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links