Last modified: 2014-02-12 23:53:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37910, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35910 - MobileFrontend should not use Makefile to make minified javascript
MobileFrontend should not use Makefile to make minified javascript
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-12 12:54 UTC by Amir E. Aharoni
Modified: 2014-02-12 23:53 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2012-04-12 12:54:49 UTC
In a mini-hackathon with MaxSem and vvv i installed the MobileFrontend extension and tried it with my local test wiki.

It gave me 8 errors and loading *.min.js on Firefox Firebug console and 4 similar errors on the Chrome dev tools. MaxSem found that it may have something to do with the "<!--[if gt IE 9]><!-->" before lines such as

<script type="text/javascript" src="/ahawiki/extensions/MobileFrontend/javascripts/application.min.js?version="></script>

It's in ApplicationTemplate.php line 70.
Comment 1 Sam Reed (reedy) 2012-04-12 12:58:07 UTC
(In reply to comment #0)
> In a mini-hackathon with MaxSem and vvv i installed the MobileFrontend
> extension and tried it with my local test wiki.
> 
> It gave me 8 errors and loading *.min.js on Firefox Firebug console and 4
> similar errors on the Chrome dev tools. MaxSem found that it may have something
> to do with the "<!--[if gt IE 9]><!-->" before lines such as
> 
> <script type="text/javascript"
> src="/ahawiki/extensions/MobileFrontend/javascripts/application.min.js?version="></script>
> 
> It's in ApplicationTemplate.php line 70.

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=tree;f=javascripts;h=ee6aa8c99d584f4ab3fdc24d450efd41a2050e85;hb=HEAD

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=blob;f=Makefile;h=7680b5aa187d135bbcb7e8fa483776e27ee03e55;hb=HEAD

You needed to run the Makefile to generate the minified versions (or steal the files from elsewhere)
Comment 2 Max Semenik 2012-04-12 13:00:49 UTC
Sam, key  here is <!--[if gt IE 9]>. I assure you, he saw it not on IE > 9, as the matter of fact it wasn't IE at all.
Comment 3 Jon 2012-04-12 15:32:56 UTC
What version of Firefox? I just tried on latest build and no problem.
Please confirm that make minified was run or alternatively add

	$wgMFConfigProperties = array( 'minifyJS' => false  );

to LocalSettings.php and see if that solves the problem..

My ApplicationTemplate.php has <!--[if gt IE 9]><!--> at line 96 - are you sure you up to date?
Comment 4 Amir E. Aharoni 2012-04-12 19:52:31 UTC
Jon, maybe you did run the makefile as Reedy says, so you don't experience the symptoms.
Comment 5 Jon 2012-04-13 09:19:41 UTC
I spoke to MaxSem and he said the Makefile was the problem.

This is thus related to bug 34986 - it is obviously confusing having a Makefile in our projects and we should move to resource loader to remove this problem.
Comment 6 Max Semenik 2012-05-22 19:07:40 UTC
Fixed with a switch to ResourceLoader in b76bd2ad2e6709454128b2b37e3dec3eb3e7ae0d / https://gerrit.wikimedia.org/r/#/c/7670/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links