Last modified: 2014-10-29 21:10:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37942, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35942 - Implement unit test to compare en and qqq localisation files
Implement unit test to compare en and qqq localisation files
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, i18n
Depends on:
Blocks: 35943
  Show dependency treegraph
 
Reported: 2012-04-13 07:46 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-10-29 21:10 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2012-04-13 07:46:35 UTC
We often have people adding new messages to En but forgetting about their description in Qqq and in messages.inc

Similarly, we sometime remove messages from En but forget about removing them from Qqq and messages.inc

We need a test to compare all the three array of messages and report a failure whenever a message should be added or removed to Qqq / messages.inc  taking En as a reference.

getUntranslatedMessages( $code ) from maintenance/language/languages.inc could help us there.
Comment 1 Niklas Laxström 2012-04-13 08:11:03 UTC
Need to consider that we have considerable backlog in message documentation, so that we only complain about newly added messages.
Comment 3 db [inactive,noenotif] 2012-04-15 19:53:23 UTC
btw: removing is done automatically like all other languages from the message files on next rebuild
Comment 4 Antoine "hashar" Musso (WMF) 2012-04-20 16:11:54 UTC
Some tests as https://gerrit.wikimedia.org/r/5438

There is even a test checking all our languages are 100% translated ;-]
Comment 5 Antoine "hashar" Musso (WMF) 2012-04-23 08:54:39 UTC
Reverted and sent again as https://gerrit.wikimedia.org/r/5550

The problem now is that the tests detects messages from extensions as missing from messages.inc (which they are). We need a way to detects messages coming from extensions which might not be possible :(
Comment 6 Antoine "hashar" Musso (WMF) 2012-10-02 08:53:02 UTC
I have updated Gerrit change #5550. I have hacked the l10n cache to let us rebuild a cache without extension messages. That let us test only core messages.

The tests testLanguagesAreCompletelyTranslated are failing since some messages are not translated and we only test out a subset of languages for now.
Comment 7 Matthew Flaschen 2013-06-27 06:20:12 UTC
Speaking of extensions, the same concept (though probably with a slightly different implementation) applies to extensions.  We should test to make sure there are qqq messages for every en message defined in the extension's message file.
Comment 8 This, that and the other (TTO) 2014-08-01 07:45:10 UTC
According to the abandon comment at Gerrit change #5550, this was superseded by https://www.npmjs.org/package/grunt-banana-checker. Also, messages.inc is no longer a thing.
Comment 9 Antoine "hashar" Musso (WMF) 2014-08-01 08:12:44 UTC
Reopening since the banana checker is not being run yet.
Comment 10 Gerrit Notification Bot 2014-10-28 20:56:42 UTC
Change 169579 had a related patch set uploaded by Umherirrender:
Tests: Compare en.json and qqq.json message keys

https://gerrit.wikimedia.org/r/169579
Comment 11 Gerrit Notification Bot 2014-10-29 21:08:14 UTC
Change 169579 abandoned by Krinkle:
Tests: Compare en.json and qqq.json message keys

https://gerrit.wikimedia.org/r/169579
Comment 12 Umherirrender 2014-10-29 21:10:17 UTC
banana-checker running since some weeks or month

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links