Last modified: 2012-05-28 19:55:54 UTC
The current use of STDOUT in the output functions of core/maintenance/Maintenance.php is problematic for PHPUnit testing, as we cannot meaningfully rewire it without causing much trouble. For the cli sapi, Maintenance currently uses STDOUT, for other sapis, it uses print. If we'd change STDOUT to prints regardless of the sapi, this would solve the problems for testing. And by what I have seen from the maintenance code, this should not cause problems. ... But I am just a newbie :D Are there any reasons to stick to STDOUT, or corner cases that would require STDOUT?
Patch to remove the STDOUTs that cause problems has been committed upstream. Git commit: 0c33345146fc6cfb05b25614d923b875cc4cfd5b Gerrit link: https://gerrit.wikimedia.org/r/#/c/4981/
