Last modified: 2013-02-19 22:19:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37967, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 35967 - git-review uses bug number rather than a local branch as gerrit's "topic name"
git-review uses bug number rather than a local branch as gerrit's "topic name"
Status: NEW
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: upstream
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-04-14 03:30 UTC by Krinkle
Modified: 2013-02-19 22:19 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2012-04-14 03:30:11 UTC 
Steps to reproduce:
1.
Local checkout of mediawiki/core.git

2.
git co -b 2012/foobar

3.
(edit files)

4.
git commit; with a message that doesn't mention a bug number in the first 5 lines and somewhere a long the line it makes a mention of 3 bugs (not even in parentheses), just like "foo bar bug 123, 456 (and bug 789 also)".

5.
It will then have submitted it as topic: bug/123 instead of 2012/foobar.

---

I like the automatic topic but it should not happen if:
* I have a good local branch name already
* Did not mention the bug on the first line
* It wasn't the only bug mentioned
Comment 1 Chad H. 2012-04-14 22:16:42 UTC 
You can work around this by manually specifying a topic on `git review`

Should be filed upstream.
Comment 2 Andre Klapper 2013-02-19 19:27:42 UTC 
(In reply to comment #1)
> Should be filed upstream.

Upstreamed as https://bugs.launchpad.net/git-review/+bug/1130330
Comment 3 Andre Klapper 2013-02-19 22:19:31 UTC 
Krinkle: Followup questions in the upstream report by Marcin...
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links