Last modified: 2013-02-01 11:26:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37982, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35982 - [upstream] Dependency graph points to localhost:8080
[upstream] Dependency graph points to localhost:8080
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Lowest trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: upstream
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-14 23:41 UTC by Tim Landscheidt
Modified: 2013-02-01 11:26 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tim Landscheidt 2012-04-14 23:41:22 UTC
When looking at https://integration.mediawiki.org/ci/view/All/job/MediaWiki-postgres-phpunit/depgraph-view/? with Konqueror, Firefox or Chrome, the link in the graph points to http://localhost:8080/ci/view/All/job/MediaWiki-postgres-phpunit/.

  Advice at https://issues.jenkins-ci.org/browse/JENKINS-13446 was that this is "likely" a misconfiguration on WMF's side and could be amended by setting "Jenkins URL" to "https://integration.mediawiki.org/ci" at https://integration.mediawiki.org/ci/configure.  If it isn't, please either follow up here or at Jenkins.
Comment 1 Sam Reed (reedy) 2012-04-15 18:22:27 UTC
Nope...

Jenkins URL is set to https://integration.mediawiki.org/ci/
Comment 2 Tim Landscheidt 2012-04-15 19:01:04 UTC
Thanks.  I'll then leave this bug here open until the issue has been resolved upstream.
Comment 3 Antoine "hashar" Musso (WMF) 2012-07-04 08:03:40 UTC
Still there with Jenkins 1.472 and Dependency Graph 0.2.

Source code is on github at https://github.com/jenkinsci/depgraph-view-plugin The culprit is src/main/java/hudson/plugins/depgraph_view/DotStringGenerator.java which does the following:

private String projectToNodeString(AbstractProject<?, ?> proj) {
        return escapeString(proj.getFullDisplayName()) +
                " [href=" +
                getEscapedProjectUrl(proj) + "]";
}

private String getEscapedProjectUrl(AbstractProject<?, ?> proj) {
        return escapeString(Hudson.getInstance().getRootUrlFromRequest() + proj.getUrl());
}

getRootUrlFromRequest is most probably getting the URL based on whatever HTTP GET Jenkins received. In our setup, there is a proxy in front of Jenkins and hence any requests are made to 127.0.0.1:8080.

The plugin need to instead use whatever "Jenkins URL" is configured.
Comment 4 Antoine "hashar" Musso (WMF) 2012-07-04 08:08:10 UTC
Our Apache conf makes https://integration.mediawiki.org/ci to be proxied to http://localhost:8080/ci

ProxyPass               /ci     http://localhost:8080/ci
ProxyPassReverse        /ci     http://localhost:8080/ci
ProxyRequests           Off

<Proxy http://localhost:8080/ci*>
        Order deny,allow
        Allow from all
</Proxy>
Comment 5 Antoine "hashar" Musso (WMF) 2012-07-04 08:09:10 UTC
I updated upstream bug : https://issues.jenkins-ci.org/browse/JENKINS-13446

Assigning to me so I can track the issue, fill free to takeover if needed.

Lowering priority since that is not really a trouble.
Comment 6 Antoine "hashar" Musso (WMF) 2012-07-17 08:13:45 UTC
Moving bug back in the pool, just keeping CC:
Comment 7 Antoine "hashar" Musso (WMF) 2012-12-02 18:46:47 UTC
apparently solved on Nov 13th by version 0.5
Comment 8 Andre Klapper 2013-01-26 00:40:33 UTC
(In reply to comment #7)
> apparently solved on Nov 13th by version 0.5

Hashar: Are there plans to deploy this Jenkins version?
Comment 9 Antoine "hashar" Musso (WMF) 2013-02-01 11:26:26 UTC
Fixed! :-) https://integration.mediawiki.org/ci/depgraph-view/?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links