Last modified: 2012-04-20 23:28:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38049, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 36049 - HTMLForm textarea field does not support 'placeholder'
HTMLForm textarea field does not support 'placeholder'
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-04-17 22:59 UTC by Arthur Richards
Modified: 2012-04-20 23:28 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Arthur Richards 2012-04-17 22:59:20 UTC 
While the 'text' form field supports the 'placeholder' tag, 'textarea' does not.
Comment 1 Arthur Richards 2012-04-17 23:22:54 UTC 
Resolved at https://gerrit.wikimedia.org/r/#change,5212,patchset=1
Comment 2 Arthur Richards 2012-04-20 23:16:25 UTC 
Platonides brought up an excellent point in code review in regards to an oversight I made when doing:
if ( !empty( $this->mParams['placeholder'] ) ) {
			$attribs['placeholder'] = $this->mParams['placeholder'];
		}
He said:
"What if the placeholder was a 0 ?"

This should probably be handled with isset() rather than !empty().
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links