Last modified: 2014-06-17 21:09:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38067, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36067 - Graph format showing legend only if both graphcolor and graphlabel are set to "Yes"
Graph format showing legend only if both graphcolor and graphlabel are set to...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticResultFormats (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Jeroen De Dauw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-18 14:40 UTC by icarnevale
Modified: 2014-06-17 21:09 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description icarnevale 2012-04-18 14:40:32 UTC
In SRF 1.7.1 when defining ask with parameter "format=graph", the graph legend is only shown when both parameters graphcolor and graphlabel are set to "Yes".
This is due to a logical "&&" in function getGVForDataValue of extensions/SemanticResultFormats/GraphViz/SRF_Graph.php:

     if ( $this->m_graphLabel && $this->m_graphColor ) {

In older version (1.5.2) there were a logical "||"

if ( ( $this->m_graphLabel == true ) || ( $this->m_graphColor == true ) ) {

Trying to use "||" instead of "&&" the graph legend is shown, so this may be a possible solution.
Comment 2 Keith Welter 2014-06-17 21:09:35 UTC
I'm still seeing this bug in SRF version 1.9.1.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links