Last modified: 2013-11-26 04:19:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38142, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36142 - Suppressed edit summary remains cached in revision view while not logged in
Suppressed edit summary remains cached in revision view while not logged in
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Revision deletion (Other open bugs)
unspecified
All All
: High major with 1 vote (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-21 09:38 UTC by Mailer Diablo
Modified: 2013-11-26 04:19 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mailer Diablo 2012-04-21 09:38:02 UTC
Bug replicated at http://en.wikipedia.org/w/index.php?title=User:Mailer_diablo/Bugtest&diff=488463971&oldid=488463573

The suppressed edit summary of diff 488463573 is visible while not logged in, as it remains cached inside the system. 

This is achieved only when an Anonymous editor views the URL first *before* it was suppressed. If it is done after, this bug is not replicated.

Not a good thing since suppression is used at times to deal with time-sensitive issues of personal info.
Comment 1 Mailer Diablo 2012-04-25 00:16:16 UTC
Just received a second complaint that with the same situation above, that the editor/IP name also remains cached and viewable by anonymous/logged-out users even after it has been suppressed.
Comment 2 Rob Lanphier 2012-04-26 18:34:38 UTC
Aaron, can you advise on how we should handle this (if we can)?  I guess we would have to send out an htcp purge on delete, but sounds like we'd have to do it for every permutation of bad revision and good revision in the revision list.
Comment 3 Aaron Schulz 2012-04-27 22:37:34 UTC
I assume that diffs can probably just send nocache headers to the squids.
Comment 4 Tim Starling 2012-05-21 00:59:52 UTC
(In reply to comment #3)
> I assume that diffs can probably just send nocache headers to the squids.

Yes, I suppose that would be the simplest solution, although it seems sad to reduce site performance in exchange for supporting such a rarely used feature.
Comment 5 Aaron Schulz 2012-05-23 17:18:36 UTC
https://gerrit.wikimedia.org/r/#/c/8622/1

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links