Last modified: 2012-04-23 00:46:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38148, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 36148 - Minor typo in code


Summary:	Minor typo in code

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	LdapAuthentication (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized trivial (vote)
Target Milestone:	---
Assigned To:	Ryan Lane

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-04-21 22:27 UTC by Solitarius
Modified:	2012-04-23 00:46 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Minor typo fix (1.25 KB, patch) 2012-04-21 22:27 UTC, Solitarius	Details
Add an attachment (proposed patch, testcase, etc.)

Description Solitarius 2012-04-21 22:27:20 UTC

Created attachment 10448 [details]
Minor typo fix

Username were changed on upgrade causing the creation of other users with the same name but with a different capitalization. For example, Gbeaudoin vs GBeaudoin.

That situation is already addressed in the LDAPAuthentication code but there was a small typo making it inactive.

Comment 1 Sumana Harihareswara 2012-04-22 09:50:45 UTC

Thanks for the patch! As you can see here

https://gerrit.wikimedia.org/r/#q,project:mediawiki/extensions/LdapAuthentication,n,z

we've moved LdapAuthentication development to Git and Gerrit, so you can directly submit a patch into our system that way.  Details:

https://www.mediawiki.org/wiki/Git/Workflow

https://www.mediawiki.org/wiki/Developer_access

Comment 2 Solitarius 2012-04-23 00:46:28 UTC

Fixed on change 5589.

https://gerrit.wikimedia.org/r/#change,5589

Thanks!

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links