Last modified: 2013-02-19 18:18:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38172, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36172 - Unable to open diff in Gerrit
Unable to open diff in Gerrit
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
https://gerrit.wikimedia.org/r/#chang...
: upstream
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-23 12:00 UTC by Niklas Laxström
Modified: 2013-02-19 18:18 UTC (History)
8 users (show)

See Also:
Web browser: Google Chrome
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Niklas Laxström 2012-04-23 12:00:03 UTC
See the i18n file in the url mentioned.

RangeError
arguments: Array[0]
get message: function getter() { [native code] }
get stack: function getter() { [native code] }
set message: function setter() { [native code] }
set stack: function setter() { [native code] }
type: "stack_overflow"
__proto__: Error
console.trace()
X
Y
_1b48516D3A05069B02085F4C99B3ECCB44.cache.html:206
Y1b48516D3A05069B02085F4C99B3ECCB44.cache.html:186
L1b48516D3A05069B02085F4C99B3ECCB44.cache.html:350
AWb48516D3A05069B02085F4C99B3ECCB44.cache.html:301
Mxb48516D3A05069B02085F4C99B3ECCB44.cache.html:357
opb48516D3A05069B02085F4C99B3ECCB44.cache.html:165
Jub48516D3A05069B02085F4C99B3ECCB44.cache.html:353
Pvb48516D3A05069B02085F4C99B3ECCB44.cache.html:357
UI48516D3A05069B02085F4C99B3ECCB44.cache.html:2949
wHd48516D3A05069B02085F4C99B3ECCB44.cache.html:2520
pKd48516D3A05069B02085F4C99B3ECCB44.cache.html:2961
eLc48516D3A05069B02085F4C99B3ECCB44.cache.html:2596
MLc48516D3A05069B02085F4C99B3ECCB44.cache.html:2958
(anonymous function)48516D3A05069B02085F4C99B3ECCB44.cache.html:2093
Avc48516D3A05069B02085F4C99B3ECCB44.cache.html:2229
(anonymous function)48516D3A05069B02085F4C99B3ECCB44.cache.html:2179
48516D3A05069B02085F4C99B3ECCB44.cache.html:2179Uncaught Class$QKd: Array index 277 out of range
Comment 2 Chad H. 2012-04-23 22:33:18 UTC
Possibly related to http://code.google.com/p/gerrit/issues/detail?id=1068
Comment 3 Niklas Laxström 2012-04-24 06:37:52 UTC
It's not a big diff by any means.
Comment 4 Niklas Laxström 2012-04-24 10:09:14 UTC
Ryan Lane has posted comments on this change.
I can in firefox, I can't in chrome.
Comment 5 Rob Lanphier 2012-06-21 21:14:38 UTC
Could someone file this one upstream?  Looks like we're talking about a single strange diff here, so bumping down priority
Comment 6 Niklas Laxström 2012-06-26 09:34:04 UTC
Another diff not working: https://gerrit.wikimedia.org/r/#/c/12873/3 SF_Messages.php
Comment 7 Niklas Laxström 2012-07-14 16:42:42 UTC
And another: https://gerrit.wikimedia.org/r/#/c/14488/1/languages/SF_Messages.php
Comment 9 Chad H. 2012-07-18 17:26:49 UTC
Please report this information upstream. There's nothing I can do with more links just being added.
Comment 10 Niklas Laxström 2012-07-18 18:18:18 UTC
I have not communicated with Gerrit upstream and don't want to start now.
Comment 11 Niklas Laxström 2012-07-25 17:04:04 UTC
Only today this has bothered me about five times.
Comment 12 Chad H. 2012-07-25 18:02:17 UTC
(In reply to comment #11)
> Only today this has bothered me about five times.

Ok. I get the point. Continuing to +1 and "omg this one too" and "PLZ HELP" do not help me solve this /at all/.

In case you're interested, I have been talking to upstream about how to fix this, and I'm also attempting to replicate on my local installation. Just because I haven't given daily status updates doesn't mean nothing is happening.
Comment 13 Chad H. 2012-07-25 20:10:55 UTC
Managed to replicate this locally and get a slightly more useful stacktrace.

http://p.defau.lt/?tPAD0WdwDCMLmibBxtXZ9Q

Unfortunately, I think it might be an issue with GWT upstream from Gerrit, but I'll continue to pester and find out.
Comment 14 Chad H. 2012-07-25 20:23:31 UTC
I'm pretty sure this isn't a duplicate of anything else upstream, so I filed a new issue to track it: http://code.google.com/p/gerrit/issues/detail?id=1492
Comment 15 Niklas Laxström 2012-07-25 22:00:50 UTC
Thanks Chad. I will follow the developments quietly. +1 ;)
Comment 16 Siebrand Mazeland 2012-10-25 10:14:11 UTC
At the moment all of the files mentioned to not display a diff in this issue report are "Works for me". I'm using Firefox 16.0.1 on OSX 10.8.2.
Comment 17 Siebrand Mazeland 2012-10-25 10:15:26 UTC
https://gerrit.wikimedia.org/r/#/c/29925/2/MoodBar.i18n.php was reported to not display a diff in Gerrit change #29925, but that's works for me, too.
Comment 18 Niklas Laxström 2012-10-25 14:51:21 UTC
(In reply to comment #17)
It's chrome specific, as mentioned in #c4. Updated Web Browser field.
Comment 19 Chad H. 2013-02-19 17:44:09 UTC
I believe this was fixed, I can't seem to replicate in Chrome for any of the above mentioned diffs.
Comment 20 Andre Klapper 2013-02-19 18:18:44 UTC
Cannot reproduce either in Chrome 24.0.1312.69 with the given URLs (being not logged in to Gerrit).

<^demon> It was probably https://code.google.com/p/gerrit/issues/detail?id=1759.
<^demon> Or https://code.google.com/p/gerrit/issues/detail?id=735
<^demon> But one of those two definitely fixed 1492

Closing as FIXED.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links