Last modified: 2014-02-12 23:55:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38190, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36190 - Expanding/Collapsing sections is slow
Expanding/Collapsing sections is slow
Status: RESOLVED WORKSFORME
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 36189
  Show dependency treegraph
 
Reported: 2012-04-24 01:25 UTC by Tomasz Finc
Modified: 2014-02-12 23:55 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tomasz Finc 2012-04-24 01:25:33 UTC
Even on fast phones like the Nexus S using the native browser expanding/collapsing sections is sluggish.
Comment 1 Arthur Richards 2012-04-25 16:44:34 UTC
Also true for the Galaxy Nexus (ice cream sandwich).
Comment 2 Jon 2012-04-25 23:56:39 UTC
This seems to be effecting ICS pre version 4.0.3
See http://code.google.com/p/android/issues/detail?id=24833

Tomasz - I'm guessing your Nexus S is also on ICS ? 

We could disable animations for this browser... alternatively I could look into scraping the use of transitions altogether and rewriting toggling to not use them.
Comment 3 Tomasz Finc 2012-04-26 00:07:47 UTC
I'm testing on a Nexus S running Android 2.3.6 with the native browser
Comment 4 Jon 2012-04-26 00:54:57 UTC
I got Tomasz to test this and it seems his problem was solved by  https://gerrit.wikimedia.org/r/5801

To deal with ICS which checking with Brion and Arthur seems to be specific to 4.0.2 (see above android issue) https://gerrit.wikimedia.org/r/5873 seems to take care of this. Arthur / Brion please confirm this and reopen ticket if this is not the case.
Comment 5 Arthur Richards 2012-04-26 01:11:15 UTC
This fix takes away the toggleable sections, so there is definitely no more flicker :p  I'm having a hard time deciding what is worse - the flicker or an intolerably long article. The San Francisco article feels utterly unnavigable to me without folded sections. Is it possible to toggle the sections but just have no animation?
Comment 6 Jon 2012-04-26 01:29:37 UTC
I thought that's what I did.. I've obviously done it wrong in state of tiredness... will fix tomorrow!
Comment 7 Jon 2012-04-26 01:33:48 UTC
Max height should only be applied to .togglefix I think this was a bad merge.
Comment 8 Jon 2012-04-26 10:52:54 UTC
Follow up in https://gerrit.wikimedia.org/r/5879
Comment 9 Arthur Richards 2012-04-26 17:56:33 UTC
Jon, even with that fix the sections are not toggle-able :(  I am seeing just the full article.
Comment 10 Arthur Richards 2012-04-27 22:43:22 UTC
The issue I mentioned with sections being non-toggle-able was the result of another bug (https://bugzilla.wikimedia.org/show_bug.cgi?id=36306) which has been resolved in master. The aforementioned changes though still do not resolve the flickering issue on ICS (4.0.2) when toggling the sections. However, since this is due to a bug in ICS, perhaps there's not much else that we can do until Google and cell providers push updates to 4.0.3/4.0.4.
Comment 11 Jon 2012-04-30 19:24:46 UTC
Arthur I checked this with brion
If you are still getting this in the latest master can you
* reopen this
* put at the top of application.js on a dev version the following code:
var ua = navigator.userAgent;
alert(ua);
* comment on the ticket with what this alerts

I'm hoping it's a cache issue and if not that something to do with a slightly different user agent...

Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links