Last modified: 2012-09-28 05:53:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38273, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36273 - jquery.footHovzer module should not cause a scroll bar to appear if total content is shorter than window height
jquery.footHovzer module should not cause a scroll bar to appear if total con...
Status: NEW
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.19
All All
: Low minor (vote)
: Future release
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-26 14:34 UTC by Niklas Laxström
Modified: 2012-09-28 05:53 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Niklas Laxström 2012-04-26 14:34:31 UTC
If the page does not fill the full screen, there is useless scrollbar in Chrome with the Vector skin (it allows scrolling down about the height of the debug toolbar).

Git bisect identified 2bed75d951ce77dd22ebf8059fad3f173c856c0b as the culprit.
Comment 1 Krinkle 2012-04-26 15:02:00 UTC
Lowering priority since it only affects debug mode and only on short pages, and not really blocking the debug proces.

I already have a fix for this which I'll commit later. The fix is as follows: Instead of manipulating body paddingBottom (which causes this bug but also another bug: the paddingBottom is collapsing with the padding of the footer, causing it to not fully reserve the space).. instead, use an empty spacer element at the bottom of the document (right before or after the hoving container itself), that we set the height on.

Confirmed fix in Vector and Monobook on localhost, if we make it, should also be backported to 1.19 (which is where this was introduced). This module didn't exist yet in 1.18, although in 1.18 this logic was duplicates in a few places, but lets not hunt that down for such a minor issue.
Comment 2 Niklas Laxström 2012-04-26 15:05:12 UTC
FYI I also see it in non-debug mode.
Comment 3 Krinkle 2012-04-27 08:28:38 UTC
(In reply to comment #2)
> FYI I also see it in non-debug mode.

I was referring to the overal mode of the wiki (not the resourceloader "debug" mode setting in particular).

The debug tool bar (and thus this bug) only show if $wgDebugToolbar = true; which it shouldn't be for a production wiki.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links