Last modified: 2012-05-01 20:37:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38294, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36294 - views and diffs should be distinguishable for CSS
views and diffs should be distinguishable for CSS
Status: NEW
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.20.x
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-27 08:49 UTC by vlakoff
Modified: 2012-05-01 20:37 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description vlakoff 2012-04-27 08:49:43 UTC
<body> tag has the same class attributes for "normal view" and "diff", for example:

http://en.wikipedia.org/wiki/Foobar
and
http://en.wikipedia.org/w/index.php?title=Foobar&diff=prev&oldid=482777894

It would be very useful for CSS styling to be able to distinguish these pages through <body> classes
Comment 1 Krinkle 2012-04-27 10:07:21 UTC
The <body> contains action- prefixed  class names (e.g. action-view, action-history, action-edit etc.). However "diff' is not an action, but a component of the view action.

It is not a different page action or layout, it therefor doesn't make sense to style the entire page differently just because it contains a diff component.

The diff component itself can be styled by using the css hooks of the diff component:

- table.diff
- .diff-marker
- .diff-content
- .diff-otitle
- .diff-ntitle
- .diff-lineno
- .diff-deletedline
- etc. (See also ./resources/mediawiki.action/mediawiki.action.history.diff.css)

If you need a selector for the entire page, could you elaborate on a use case?
Comment 2 vlakoff 2012-04-27 10:13:54 UTC
On the French wiki homepage, we hide the H1:

http://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Accueil_principal

However, the H1 is also hidden on this page's diffs:

http://fr.wikipedia.org/w/index.php?title=Wikip%C3%A9dia:Accueil_principal&diff=75110565&oldid=prev

For consistency, it would be great to hide the H1 only on the viewed page, and nowhere else.

Note that the issue also concerns the English wiki

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links