Last modified: 2012-05-01 21:45:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38302, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36302 - Style of the gadget has been loaded double.
Style of the gadget has been loaded double.
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Gadgets (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 35126
  Show dependency treegraph
 
Reported: 2012-04-27 14:34 UTC by Frozen-mikan
Modified: 2012-05-01 21:45 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Frozen-mikan 2012-04-27 14:34:53 UTC
I was confirmed in the gadget of the English Wikipedia.
The name of the gadget is OldDiff.
Browser is Chrome.

Procedure is as follows.

* Open the tab "gadgets" of personal settings, check the item of "Display diffs with the old yellow / green colors and design.", Then save it.
* To display the screen of any difference.
* Open the developer tools, to check the status of the style applied.
* Select the style elements of the gadget has been applied. Make sure that the style of the gadget has been applied twice by the script and CSS.

After that, I was also confirmed in the Japanese version.
Comment 1 Krinkle 2012-05-01 21:39:36 UTC
This is not a ResourceLoader bug but a bug in the Gadgets extension. It does this on purpose, although you are correct that it should not be needed.
Comment 2 Krinkle 2012-05-01 21:45:53 UTC
This line is where it adds it twice, once the styles (on top) and once as a regular module:

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Gadgets.git;a=blob;f=Gadgets_body.php;h=4869d8c25e4728e25c6cf0b1c87bc951dddce05a;hb=HEAD#l149

It does that because gadgets are always in the <body> load queue, so styles intended for elements of the core mediawiki skin should be loaded in the <head> so that there is no flash.

In Gadgets 2.0 this has been fixed:

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Gadgets.git;a=blob;f=Gadgets.hooks.php;h=8d899dc48d730dca334c8a702936f20db349d315;hb=RL2#l359

And in Gadgets 2.0 there is a new definition property to choose which queue the module should be loaded from.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links