Last modified: 2012-08-30 19:36:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38329, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36329 - Accesskey tooltips for Firefox 14 on Mac should use "ctrl-option-" prefix
Accesskey tooltips for Firefox 14 on Mac should use "ctrl-option-" prefix
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.20.x
All All
: Low normal (vote)
: 1.20.0 release
Assigned To: Krinkle
https://bugzilla.mozilla.org/show_bug...
: javascript
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-28 22:30 UTC by Minh Nguyễn
Modified: 2012-08-30 19:36 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
“ctrl-option-” for Firefox 14+ on Mac; “ctrl-alt-” → “ctrl-option-” for Safari on Mac (958 bytes, patch)
2012-04-28 22:30 UTC, Minh Nguyễn
Details

Description Minh Nguyễn 2012-04-28 22:30:22 UTC
Created attachment 10483 [details]
“ctrl-option-” for Firefox 14+ on Mac; “ctrl-alt-” → “ctrl-option-” for Safari on Mac

Firefox has switched to Ctrl+Opt for accesskeys on the Mac as of version 14. [1][2] The file resources/mediawiki/mediawiki.util.js needs to be adjusted to use the right prefix in tooltips.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=728103
[2] https://developer.mozilla.org/en/HTML/Global_attributes#attr-accesskey
Comment 1 Sumana Harihareswara 2012-04-29 23:47:44 UTC
Thanks, Minh Nguyễn!  Please request developer access

https://www.mediawiki.org/wiki/Developer_access

so you can easily suggest these fixes directly via Git next time.  Thanks for the patch.
Comment 2 Minh Nguyễn 2012-04-30 15:28:12 UTC
No problem. I’ll look into requesting access.
Comment 3 Sumana Harihareswara 2012-05-25 02:38:14 UTC
Thanks again for the patch.  Have you had any trouble in using developer access to directly suggest it into our Git source control system?

https://www.mediawiki.org/wiki/Developer_access

https://www.mediawiki.org/wiki/Git/Workflow#How_to_submit_a_patch
Comment 4 matanya 2012-08-05 12:05:20 UTC
Pushed your patch as :

https://gerrit.wikimedia.org/r/#/c/17687/
Comment 5 Niklas Laxström 2012-08-05 12:24:02 UTC
See also bug 37239.

(In reply to comment #4)
> https://gerrit.wikimedia.org/r/#/c/17687/
Wrong bug?
Comment 6 matanya 2012-08-05 12:30:04 UTC
(In reply to comment #5)
> See also bug 37239.
> 
> (In reply to comment #4)
> > https://gerrit.wikimedia.org/r/#/c/17687/
> Wrong bug?

yes.

should be: https://gerrit.wikimedia.org/r/#/c/17689/
Comment 7 Krinkle 2012-08-12 06:35:13 UTC
Removing "patch-need-review" keyword. This is now in the Gerrit queue, there is no patch to review here on BugZilla.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links