Last modified: 2012-10-25 17:36:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38336, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36336 - ViewVC crashes on /trunk/tools/viaf/viaf.bookmarklet.bootloader.js (corrected utf8 in a follow-up commit)
ViewVC crashes on /trunk/tools/viaf/viaf.bookmarklet.bootloader.js (corrected...
Status: RESOLVED DUPLICATE of bug 34006
Product: Wikimedia
Classification: Unclassified
Subversion (Other open bugs)
unspecified
All All
: Lowest normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-29 10:21 UTC by T. Gries
Modified: 2012-10-25 17:36 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2012-04-29 10:21:05 UTC
Just mentioning a crash due to a wrongly encoded character in commit  https://www.mediawiki.org/wiki/Special:Code/MediaWiki/115079 which crashes the CR viewer - this should however not happen and present a better message. (As we are moving to git I do _not_ expect this being fixed.)

I already corrected the wrongly encoded character in the follow-up https://www.mediawiki.org/wiki/Special:Code/MediaWiki/115080

https://svn.wikimedia.org/viewvc/mediawiki/trunk/tools/viaf/viaf.bookmarklet.bootloader.js?view=markup&pathrev=115079

An Exception Has Occurred
Python Traceback

Traceback (most recent call last):
  File "/usr/lib/viewvc/viewvc.py", line 4396, in main
    request.run_viewvc()
  File "/usr/lib/viewvc/viewvc.py", line 398, in run_viewvc
    self.view_func(self)
  File "/usr/lib/viewvc/viewvc.py", line 1811, in view_markup
    markup_or_annotate(request, 0)
  File "/usr/lib/viewvc/viewvc.py", line 1744, in markup_or_annotate
    path[-1], mime_type, encoding)
  File "/usr/lib/viewvc/viewvc.py", line 1625, in markup_stream_pygments
    encoding='utf-8'), ps)
  File "/usr/lib/pymodules/python2.6/pygments/__init__.py", line 86, in highlight
    return format(lex(code, lexer), formatter, outfile)
  File "/usr/lib/pymodules/python2.6/pygments/__init__.py", line 45, in lex
    return lexer.get_tokens(code)
  File "/usr/lib/pymodules/python2.6/pygments/lexer.py", line 137, in get_tokens
    text = text.decode('utf-8')
  File "/usr/lib/python2.6/encodings/utf_8.py", line 16, in decode
    return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode bytes in position 235-237: invalid data

I corrected the wrongly encoded character in the follow-up https://www.mediawiki.org/wiki/Special:Code/MediaWiki/115079
Comment 1 Chad H. 2012-04-29 12:36:52 UTC
I don't see a problem with CodeReview, just ViewVC. Adjusting product/component appropriately.
Comment 2 Andre Klapper 2012-10-25 17:18:19 UTC
(In reply to comment #1)
> I don't see a problem with CodeReview, just ViewVC.

In case this is an upstream issue, feel free to forward to http://viewvc.tigris.org/issues/buglist.cgi?component=viewvc&issue_status=UNCONFIRMED&issue_status=NEW&issue_status=STARTED&issue_status=REOPENED

Likely WONTFIX for Wikimedia as Git and Gerrit are dominated now.
Comment 3 Andre Klapper 2012-10-25 17:19:04 UTC
..."dominant" that should have been, obviously.
Comment 4 Chad H. 2012-10-25 17:36:55 UTC

*** This bug has been marked as a duplicate of bug 34006 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links