Last modified: 2013-04-22 16:14:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38461, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 36461 - Hitting "Enter" fails to filter list
Hitting "Enter" fails to filter list
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
PageCuration (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nischay Nahata
en.wikipedia.org/wiki/Special:NewPage...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-05-03 00:54 UTC by Steven Walling
Modified: 2013-04-22 16:14 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Steven Walling 2012-05-03 00:54:43 UTC 
Currently hitting enter/return does not reload the feed with the filters. 

If you simply choose the checkboxes or radio buttons, hitting enter does nothing. 

If you enter text in the username filter field and hit enter, the feed reloads but does not filter successfully.
Comment 1 Nischay Nahata 2012-12-30 07:09:23 UTC 
Fix attempt in https://gerrit.wikimedia.org/r/#/c/41375/

This changes fixes the issue partially, hitting enter filters only for the username field.
Comment 2 Andre Klapper 2013-03-21 10:21:52 UTC 
That 8-liner patch in Gerrit needs another review...
Comment 3 Gerrit Notification Bot 2013-04-08 17:50:05 UTC 
https://gerrit.wikimedia.org/r/41375 (Gerrit Change I4f9b9750a020b929053a04f34e59440a6308ad65) | change APPROVED and MERGED [by jenkins-bot]
Comment 4 Nischay Nahata 2013-04-08 20:24:31 UTC 
I don't think that there's a way that hitting enter on checkboxes or radio can filter the list, can it?

Therefore, closing this bug as fixed (fixed for the textbox)
Comment 5 Steven Walling 2013-04-08 20:27:43 UTC 
Yeah, text box only is definitely fine. 

Thanks for the patch Nischay!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links