Last modified: 2012-05-17 20:58:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38462, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36462 - Replacing MemcachedClient.php memcache client with PECL memcache client
Replacing MemcachedClient.php memcache client with PECL memcache client
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.20.x
All All
: High enhancement (vote)
: ---
Assigned To: Tim Starling
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-03 01:59 UTC by Rob Lanphier
Modified: 2012-05-17 20:58 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rob Lanphier 2012-05-03 01:59:58 UTC
Our current memcache implementation has a few issues (e.g. timeout failure mode, limited format support) which could be addressed.  However, the client was written before there were good standard options such as the PECL memcache client.  Per conversation with Asher and Patrick, we should replace BagOStuff with a different client.

The hope is that this will be part of our long-term solution for bug 35900
Comment 1 Rob Lanphier 2012-05-03 02:01:39 UTC
Assigned to Chris for now.  We may need to rebalance.
Comment 2 Aaron Schulz 2012-05-03 02:07:31 UTC
Also note that does evil things, like cast resources to ints to use as array keys ;)
Comment 3 Chris Steipp 2012-05-03 22:33:13 UTC
Aaron: The MemcachedPhpBagOStuff class? Or the MemcachedClient class?
Comment 4 Aaron Schulz 2012-05-03 22:36:33 UTC
(In reply to comment #3)
> Aaron: The MemcachedPhpBagOStuff class? Or the MemcachedClient class?

MemcachedClient would be ditched and MemcachedPhpBagOStuff changed to use the PECL extension instead.
Comment 5 Aaron Schulz 2012-05-06 07:15:50 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > Aaron: The MemcachedPhpBagOStuff class? Or the MemcachedClient class?
> 
> MemcachedClient would be ditched and MemcachedPhpBagOStuff changed to use the
> PECL extension instead.

Well, to support third party sites, it makes sense to keep these around but make a new MemcachedPeclBagOStuff class that uses the PECL extension.
Comment 6 Rob Lanphier 2012-05-17 20:58:13 UTC
Tim already did this work and it's committed as https://gerrit.wikimedia.org/r/#/c/7273/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links