Last modified: 2014-08-01 23:12:11 UTC
Created attachment 10501 [details] Ugly scrollbars I have 1440x900 resolution on my laptop. Yet the Gerrit interface doesn't fit in very well. It is kind of problem with too long lines in commit messages, but on the other hand those are not strictly enforced, and gerrit should handle them better. I either get ugly scrollbars or extra wide page. See the attached images.
Created attachment 10502 [details] Extra wide page
That is why we want to use short commit messages.
Also, Roan was possibly adding some CSS to line-wrap long commit messages there. I know it's not coming *soon*, but 2.4 improves the UI here a lot...just something to keep in mind.
(In reply to comment #3) > I know it's not coming *soon*, but 2.4 improves the UI here a lot...just > something to keep in mind. Here's what the interface looks like in 2.4: http://gerrit-dev.wmflabs.org/r/#/c/9/1/.gitmodules
Actually this was in 2.3, not just 2.4. It's a bit too wide for my Android devices (phone & tablet), but it's certainly usable. On my laptop, I can take the resolution down as far as 800x600 and it's still a bit too wide--but again, perfectly usable. I'm inclined to mark this WORKSFORME.
We're using Gerrit 2.4 and it doesn't look fixed to me. The computed width of my current dashboard table is 1163px, which is typical and kind of inconvenient when you have a screen width of 1050px. The V/R marks are almost never visible without horizontal scrolling. Removing the white-space:nowrap from the remaining table cells that have it improves the display enormously, see the screenshots which I will attach shortly.
Created attachment 11164 [details] Tim's dashboard in 2.4 1163px wide dashboard in 2.4
Created attachment 11165 [details] Tim's dashboard without nowrap Same dashboard view, hacked with Firebug to remove the white-space:nowrap rules.
Submitted a patch upstream to fix this. https://gerrit-review.googlesource.com/#/c/38260/ Thanks Tim, I hadn't noticed this being too wide (initial focus of the bug was on commit messages).
Merged into upstream, with a second fix to my original commit. Doubt it'll make the 2.5 release, but it'll definitely make 2.6.
Created attachment 11768 [details] Search bar way beyond the screen in 2.6 (In reply to comment #10) > Merged into upstream, with a second fix to my original commit. Doubt it'll > make > the 2.5 release, but it'll definitely make 2.6. Actually it's way worse in 2.6. With 2.4, most of the search bar was within the screen.
Previous comments were asking for wide commit messages and wide change tables to be fixed--both if which have been. The search bar wasn't brought up in previous comments at all (and I didn't do any work on it). I'm not opposed to improvements though :)
Created attachment 11775 [details] Commit message going way beyond the screen (In reply to comment #12) > Previous comments were asking for wide commit messages and wide change tables > to be fixed--both if which have been. It's also commit messages for me. I think you changed something with the logo? I see less white space next to it, good. > > The search bar wasn't brought up in previous comments at all (and I didn't do > any work on it). I'm not opposed to improvements though :) Would another bug be better, or – in general – how can one help?
We still need to wrap commit messages properly. We have a table, use it. Also, can I get a screenshot of the search bar problem and what exactly we should fix?
(In reply to comment #14) > Also, can I get a screenshot of the search bar problem and what exactly we > should fix? Quoting myself from https://gerrit.wikimedia.org/r/#/c/58082/ : «I have a 1024x768px screen and with "My" tab selected I lack 250px of space to reach the end (arrow to open settings).» That CSS change should help, I can add a screenshot... no I already did, attachment 11768 [details] look top right.
(In reply to comment #14) > Also, can I get a screenshot of the search bar problem and what exactly we > should fix? Up to and including patch set 3 of Iaedbea9b5f43ac this change doesn't actually work. The problem (screenshot of current deployment, no changes): - http://cl.ly/image/37370E3p1v2a Screenshot with Iaedbea9b5f43ac,ps3 applied: - http://cl.ly/image/0i2o2w3l0D24 What we need: - Hide logo and move everything else over (it has position absolute, hiding it doesn't collapse the layout).
Restoring the original bug summary, with addition of "horizontal scroll" specification: the new bug summary doesn't describe a problem but a specific goal regarding the problem.
*** Bug 69036 has been marked as a duplicate of this bug. ***
