Last modified: 2012-07-06 15:02:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38472, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36472 - Gerrit links for side-by-side differences don't retain "base" information
Gerrit links for side-by-side differences don't retain "base" information
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: upstream
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-03 09:44 UTC by Niklas Laxström
Modified: 2012-07-06 15:02 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Niklas Laxström 2012-05-03 09:44:23 UTC
It should be possible to give another person a link for diff of file changes between two patchsets, especially because it is hard to find how to do that, but the links don't preserve that information.
Comment 1 Chad H. 2012-07-03 13:52:35 UTC
I think this is better in 2.4. See for example:

https://gerrit-review.googlesource.com/#/c/17380/8..9/gerrit-common/src/main/java/com/google/gerrit/common/errors/ProjectCreationFailedException.java

(Should be comparing patch sets 8 and 9. Dropping the 8.. would make it compare to base)
Comment 2 Chad H. 2012-07-06 15:02:41 UTC
Confirmed this is working in 2.4.2 for us.

I went to https://gerrit.wikimedia.org/r/#/c/8120/ and compared patchsets 4 and 6 and was given the resulting url: https://gerrit.wikimedia.org/r/#/c/8120/4..6/templates/gerrit/hookconfig.py.erb

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links