Last modified: 2013-02-12 18:16:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38526, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 36526 - No red X and green tick in section "Review Requests for " on My Changes
No red X and green tick in section "Review Requests for " on My Changes
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://code.google.com/p/gerrit/issue...
: upstream
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-05-04 19:55 UTC by Umherirrender
Modified: 2013-02-12 18:16 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Umherirrender 2012-05-04 19:55:33 UTC 
Git: Visited the page "My" "Changes" gives me three section:

* Started by
* Review Requests for 
* Recently closed

The last both columns contains some information about "Verified" and "Reviewed" like +1. The column "Verified" is always empty in the section "Review Requests for ", but viewing the same change on "All" "Open", the verified is filled.
Comment 1 Chad H. 2012-05-04 20:00:14 UTC 
Definitely an upstream bug. Need to see if this is fixed in 2.4.
Comment 2 Umherirrender 2012-07-07 20:28:34 UTC 
(In reply to comment #1)
> Need to see if this is fixed in 2.4.

Looks not fixed under 2.4
Comment 3 Umherirrender 2012-09-21 15:59:45 UTC 
Looks not like a problem for the Verified column, when a change has the "Do not submit" state, that red X is also not shown in this section.

So red X and the green check mark are not displayed. Only -1 is there. I am not sure, which is the name in "gerrit language".
Comment 4 Chad H. 2012-09-21 16:08:31 UTC 
This seems to have been fixed in 2.5 for "Review requests for" and "Started By."

It's still broken for "Recently Closed." Although it could be assumed that it has 2 checkmarks...the UI still needs fixing here.
Comment 5 Umherirrender 2013-02-12 18:16:16 UTC 
Looks good with the new version (2.5.1-1266-gcc231e1). Thanks.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links