Last modified: 2012-05-08 18:24:33 UTC
It appears that the new deployment of the New Pages Feed (a.k.a. Page Triage) may have caused some malfunctions regarding blocked users. The purpose of this ticket is to 1) find out what caused the problem and 2) if it is related to New Pages Feed, make sure this doesn't happen again. Let's use the comments below to identify 1) and implement 2), as needed.
It was fairly simple. The error being thrown was “DatabaseBase::makeList: empty input”. I’m guessing you missed the commit: https://gerrit.wikimedia.org/r/#/c/6886/ Based on the code, $pageIds is an array, used as part of the where query. $dbw->update( 'pagetriage_page_tags', array( 'ptrpt_value' => $status ), array( 'ptrpt_page_id' => $pageIds, 'ptrpt_tag_id' => $tags['user_block_status'] ) ); In some cases, the select query above can return no results, e.g. $dbw->update( 'pagetriage_page_tags', array( 'ptrpt_value' => $status ), array( 'ptrpt_page_id' => array(), 'ptrpt_tag_id' => $tags['user_block_status'] ) ); So when MediaWiki tries to build the SQL query from the components it notices you have passed an array, but there are no elements. I’m not sure there are any cases where you would want to do a comparison against 0 elements, so it throws an exception as a “this shouldn’t be happening”. The fix is literally just making sure it doesn’t attempt to run that update query if there are no elements on that where condition. If there isn’t any elements, bail out of the method and don’t go any further. It’s in Git so you won’t have any regressions in future unless you remove the code ;)
