Last modified: 2012-08-20 06:54:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38631, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36631 - Validator 0.5.x does not work with Maps extension
Validator 0.5.x does not work with Maps extension
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Validator (Other open bugs)
unspecified
All All
: High blocker (vote)
: ---
Assigned To: Jeroen De Dauw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-08 09:17 UTC by Siebrand Mazeland
Modified: 2012-08-20 06:54 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Siebrand Mazeland 2012-05-08 09:17:38 UTC
Observed on translatewiki.net on page https://translatewiki.net/wiki/User:Siebrand. Pages with Maps on them do not load anymore.

Change window:
Update from: 978ab5b 2012-05-07 21:05:07 +0000
Updated to: cdc9e43 2012-05-08 09:05:06 +0000

Other observations:
* Reverting to 8db2c6dfe0463a85bc3ce1254035d5f949fbab39 makes the problem go away, but leave translatewiki.net with 'detached HEAD' state.
Comment 1 Siebrand Mazeland 2012-05-08 09:20:49 UTC
Assigning to Jeroen, but as Validator development does not go through Gerrit, I no longer have an idea where to get an online commit list or diff list.
Comment 2 Jeroen De Dauw 2012-05-08 11:51:09 UTC
Damn, thought that my new stuff was working by now... this just shows the stuff really needs tests :)

Changes for all branches can be accessed via: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Validator.git

I will test more with the Maps extension. Till the issue has been resolved, you can always switch to 0.4.x branch.
Comment 3 Jeroen De Dauw 2012-05-08 12:02:05 UTC
The particular issue reported has been fixed by https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Validator.git;a=commitdiff;h=fe604b97055ed64106ba8c64fcd295fa5bd04e8a

However, there are still issues when used with the Maps extension.
Comment 4 Jeroen De Dauw 2012-05-08 16:19:08 UTC
I can now again gets maps on master. It's likely there are remaining issues though.
Comment 5 Siebrand Mazeland 2012-05-09 11:26:22 UTC
Just put twn back on master branch for Validator. So far, so good.
Comment 6 Siebrand Mazeland 2012-05-09 11:34:34 UTC
Oops. Too soon. This was observed. Not sure though where it comes from:

[09-May-2012 11:32:08] PHP Notice:  Undefined property: IntParam::$negativesAllowed in /www/w/extensions/Validator/includes/definitions/IntParam.php on line 46
[09-May-2012 11:32:08] PHP Fatal error:  Access to undeclared static property: Param::$accumulateParameterErrors in /www/w/extensions/Validator/includes/Param.php on line 297
Comment 7 Jeroen De Dauw 2012-08-20 06:54:23 UTC
This has been fixed I guess - you've not raged to me about it more, and this code now has tests :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links