Last modified: 2014-03-11 01:05:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38636, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36636 - SkinMobile needs to be properly registered
SkinMobile needs to be properly registered
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
Feature requests (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Nobody - You can work on this!
http://bits.wikimedia.org/zh.wikipedi...
:
: 57127 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-08 10:55 UTC by Max Semenik
Modified: 2014-03-11 01:05 UTC (History)
14 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Max Semenik 2012-05-08 10:55:12 UTC
Because the system knows about it only when it's set as current skin by a hook, requests like the one in the URL field return Vector's styles. Looks like this needs core support.
Comment 1 Michelle Grover 2013-04-28 17:05:04 UTC
Assigned Mingle ticket https://mingle.corp.wikimedia.org/projects/mobile/cards/708
Comment 2 Jon 2013-05-06 23:14:04 UTC
mw.config.get( 'skin' ) currently returns vector. Now we are using minerva we should call ourselves minerva.

I was talking to Matt and CentralNotice could do with this to distinguish between skins in deciding which banner to serve.
Comment 3 Arthur Richards 2013-09-20 19:53:32 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1191
Comment 4 Bingle 2013-11-16 00:40:31 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1419
Comment 5 Gerrit Notification Bot 2013-12-20 01:21:22 UTC
Change 102866 had a related patch set uploaded by Jdlrobson:
Offer the blue pill or the red pill

https://gerrit.wikimedia.org/r/102866
Comment 6 Jon 2013-12-23 20:53:12 UTC
*** Bug 57127 has been marked as a duplicate of this bug. ***
Comment 7 Gerrit Notification Bot 2014-01-31 00:23:22 UTC
Change 102866 merged by jenkins-bot:
Beta Feature: Register mobile skin, offer users the ability to change it

https://gerrit.wikimedia.org/r/102866
Comment 8 Gerrit Notification Bot 2014-03-11 01:03:49 UTC
Change 118037 had a related patch set uploaded by Jdlrobson:
Make sure Minerva is registered as a valid skin

https://gerrit.wikimedia.org/r/118037
Comment 9 Jon 2014-03-11 01:04:10 UTC
After discussing with Ryan, we actually realised we can register it but stop it from being user facing. So that's what's happening!
Comment 10 Gerrit Notification Bot 2014-03-11 01:05:27 UTC
Change 118037 merged by jenkins-bot:
Make sure Minerva is registered as a valid skin

https://gerrit.wikimedia.org/r/118037

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links