Last modified: 2014-02-12 23:53:31 UTC
http://en.wikipedia.org/wiki/Great_Barr_Hall has its' co-ordinates scrubbed. Should be output at a relavant position.
This seems to be scrubbed on purpose.. I'm not sure if there is a good reason. The only reason I suspect is that due to the introduction of sections the coordinates appear in the top right of the section it is contained in rather than in the top right of the page. The commit message 4bc466c1 isn't very helpful "Started extracting wikitext-manipulating code into a separate, isolated class"
That commit simply moved code around, the selector in question was there since times forgotten, even Patrick doesn't quite remeber why. We have to find a way to position them though.
We could simply leave it in the markup, hide it with css and use javascript to move it into a more appropriate place. Obviously this is inaccessible for users with javascript disabled (although not such an issue with the app and actually won't make any presentational difference to the current situation we find ourselves in) Alternatively we could parse it (not sure if this a good idea) and reconstruct it at the top of the page.
They're normally just positioned with CSS, so the only problem with it on the mobile site is to make them not overlap the UI.
In the example Yuvi gives they appear for some reason in the last section when not scrubbed on the mobile site.
So they're moved to the top of the desktop site page with position: absolute; top: 0; right: 0;
Yes... but when in a section on mobile site they are absolute to the section they are contained in ...
Fixed in https://gerrit.wikimedia.org/r/7720 Note the commit message that this may need a follow up as I notice many geographical coordinates are placed at the bottom of the page instead of at the top. I'm not sure what the correct behaviour is here (whether they should be in the last section or appear outside the sections) but this should be addressed in a separate bug.
