Last modified: 2012-08-15 12:50:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38776, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 36776 - Don't check user_newtalk for anons when $wgDisableAnonTalk = true;
Don't check user_newtalk for anons when $wgDisableAnonTalk = true;
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-05-11 17:47 UTC by Liangent
Modified: 2012-08-15 12:50 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2012-05-11 17:47:46 UTC 
Currently:

$ grep wgDisableAnonTalk * -R
includes/DefaultSettings.php:$wgDisableAnonTalk = false;
includes/Linker.php:            global $wgUser, $wgDisableAnonTalk, $wgLang;
includes/Linker.php:            $talkable = !( $wgDisableAnonTalk && 0 == $userId );
$

So it's only a visual hack. The whole feature should be disabled by not checking user_newtalk at all.
Comment 1 Tyler Romeo 2012-07-27 20:58:05 UTC 
Added code to User::getNewtalk to prevent DB query in this case.

https://gerrit.wikimedia.org/r/16855
Comment 2 matanya 2012-08-15 12:50:23 UTC 
patch merged. closing.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links