Last modified: 2012-07-02 06:32:31 UTC
The indicator on the watchlist (bolded title) and history pages (green box with "updated since my last visit") is ok, but to allow more comprehensive styling it would be helpful if there were a class on the containing <li> (or <table> for the 'enhanced' watchlist) to indicate this as well. If CSS had some way to target "any LI element that contains a STRONG.mw-watched" this wouldn't be necessary. Gerrit change will be posted shortly; I need to file the bug first to get the bug number for the commit message.
Gerrit change is https://gerrit.wikimedia.org/r/7357
Two thoughts: a) I don't think the <strong> tag is necessary and it would help to eliminate it (or change it to a <span>) in favor of styling entirely via CSS. There's no need for it as long as classes are applied properly instead. The styling can then be accomplished using the CSS stylesheets. b) A second class should also be added separately to the <li> or <table> lines that are unaffected, ie. watchlist items that have already been checked. This would allow for greater CSS flexibility for those who want to de-emphasize items they've already viewed, instead of -or- in addition to emphasizing new items.
Gerrit change #7357 has been updated with the above suggestions and the suggestions provided on code review. (Hope I did it correctly)
-patch-need-review: Now in Gerrit and being reviewed -version-1.20: This has been in MediaWiki for a long time, not recently. For lack of an exact version, choosing unspecified for now. +milestone-1.20.0: This will be landing in 1.20 if it is merged soon (which it appears to be)
Merged in I90bc95db061274d4de782578a4e91f954481adfd.
