Last modified: 2012-05-15 09:37:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38797, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36797 - Some 'centralnotice-*-button' messages are either unused or badly documented
Some 'centralnotice-*-button' messages are either unused or badly documented
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Amir E. Aharoni
: fun-com, fundraising, i18n
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-12 20:32 UTC by Amir E. Aharoni
Modified: 2012-05-15 09:37 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2012-05-12 20:32:09 UTC
I found the documentation for these messages confusing and unclear:
* centralnotice-hide-button
* centralnotice-collapse-button
* centralnotice-expand-button

I tried to search for them in the code to write better documentation, but couldn't find where they are used.

If they are not used any more, they should be removed. If they are used, they should be better documented and easier to find in the code.
Comment 1 Ryan Kaldari 2012-05-14 17:36:13 UTC
Those messages are ancient and no longer used. They should be removed.
Comment 2 Amir E. Aharoni 2012-05-15 09:37:17 UTC
Removed in https://gerrit.wikimedia.org/r/#/c/7714/ .

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links