Last modified: 2012-07-09 19:40:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38837, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36837 - PageTriage should recognize the difference between a patrol action and an autopatrol action
PageTriage should recognize the difference between a patrol action and an aut...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
PageCuration (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-14 14:04 UTC by Oliver Keyes
Modified: 2012-07-09 19:40 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Oliver Keyes 2012-05-14 14:04:17 UTC
ClueBotNG appears as the top reviewer. This is kinda impressive, cuz ClueBot is, well, a bot, and doesn't patrol :P.

The problem appears to be that the mechanism doesn't distinguish between patrols and autopatrols, and cluebot creates-and-patrols a lot of IP talkpages.
Comment 1 Ryan Kaldari 2012-05-15 17:33:46 UTC
The correct way for us to fix this is probably to add a new field to pagetriage_log indicating the natural of the action: autopatrol, newpages, or pagetriage. This is not a trivial fix, however, and will require some planning. In the meantime, we could just exclude bots completely, if you think that makes sense. We could actually do that before the deployment today.
Comment 2 Oliver Keyes 2012-05-31 18:53:53 UTC
That works!
Comment 3 bsitu 2012-06-12 23:51:09 UTC
Status difference fix: https://gerrit.wikimedia.org/r/#/c/10675/
Top reviewer stats fix: https://gerrit.wikimedia.org/r/#/c/11129/

Upon deployment, existing data should be flushed as they have incorrect status
Comment 4 bsitu 2012-06-14 22:42:46 UTC
We introduced patrolled, auto-patrolled status in today's deployment and I have removed the != 'ClueBot' check from the stat query.  Since the old records will still have auto-patrolled status as reviewed, 'ClueBot' may appear again as top reviewer, this is not a bug. Since the stat looks back at 7 days, 'ClueBot' will be gone from the list in at most 7 days or we can go ahead and remove all existing data.
Comment 5 bsitu 2012-07-09 19:40:37 UTC
Marking this as fixed because code has been deployed to production and haven't seen any odd behaviour

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links