Last modified: 2012-06-06 21:53:23 UTC
The old code review tool did this. In gerrit you have to download the files, zipped!
This is a regression.
Chad or Niklas, could you add a feature request on the Gerrit bugtracker? Alternatively, if you provide me a link to the relevant section of the old tool documentation, I can prepare it. Relevant tracker link: http://code.google.com/p/gerrit/issues/list
Actually, I believe we can adjust this on a mimetype-by-mimetype basis...see: https://gerrit.wikimedia.org/r/Documentation/config-gerrit.html#_a_id_mimetype_a_section_mimetype
Pushed Gerrit change #10352. Once this is merged hopefully we can mark this fixed.
Images still don't show side-by-side, but they'll at least show up in the UI now rather than a zip download. Good example is Gerrit change #9591. How's that look Niklas?
unified shows them side by side
(In reply to comment #6) > unified shows them side by side Ah, indeed it does. Totally missed that.
This is a little bit clumsy UI choice and not intuitive, as it's the opposite behavior than the text comparison, where the unified diff prints its output in one column. Shouldn't we fill an upstream bug to swap the two columns?
(In reply to comment #8) > This is a little bit clumsy UI choice and not intuitive, as it's the opposite > behavior than the text comparison, where the unified diff prints its output in > one column. > > Shouldn't we fill an upstream bug to swap the two columns? Go for it :)
Okay, see bug #37382.
