Last modified: 2014-02-12 23:53:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38893, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36893 - Unnecessary "<h2></h2>" tags created in Main page by MF extension
Unnecessary "<h2></h2>" tags created in Main page by MF extension
Status: VERIFIED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-16 05:14 UTC by Quim Gil
Modified: 2014-02-12 23:53 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Quim Gil 2012-05-16 05:14:34 UTC
MobileFrontend extension adds unnecessary "<h2></h2>" tags when reformatting the Main page. The result is plenty of extra white in the mobile Main pages suffering this problems. It seems to be linked to <div> tags in the original source but I'm not sure.

Look this example, using the MF version from git master-0880467 (1012-05-15):

- http://espiral.org/wiki/Inicio

- Wiki format in the edit form:

<div id="mf-intro" style="font-size:162%; border:none; margin:0; padding:.1em; color:#000;">[[Proyecto espiral|{{NUMBEROFARTICLES}} propuestas conectadas]]</div>
<div id="mf-intro-pie" style="top:+0.2em; font-size:95%;">para mejorar tu vida y tu entorno</div>

- Rendered in mobile version:

<div id="mf-intro" style="font-size:162%; border:none; margin:0; padding:.1em; color:#000;"><a href="/wiki/Proyecto_espiral" title="Proyecto espiral" class="mw-redirect">196 propuestas conectadas</a></div>
<br clear="all">
<h2></h2>
<div id="mf-intro-pie" style="top:+0.2em; font-size:95%;">para mejorar tu vida y tu entorno</div>

("<br clear="all">" is also created next to the h2 but it is probably ok to have it and play safe)

The desktop version doesn't add anything between both <div>.
Comment 1 Jon 2012-05-16 16:18:54 UTC
A bit of background in case you are not aware (as it is not obvious) -
currently title attributes are responsible for headings on the homepage. See
bug 32583 for more details. What's happening here is when no title attribute is
set an empty h2 is being printed

This is addressed in https://gerrit.wikimedia.org/r/7797
Comment 2 Quim Gil 2012-05-17 04:54:01 UTC
Yes! Tested with latest master branch & this works. Thank you for the fast response. Verifying.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links