Last modified: 2012-05-21 07:39:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38900, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 36900 - Coding style issues in interwiki
Coding style issues in interwiki
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Interwiki (extension) (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Amir E. Aharoni
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-05-16 09:48 UTC by Niklas Laxström
Modified: 2012-05-21 07:39 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2012-05-16 09:48:34 UTC 
I identified these types of coding style issues:
* Use of == comparison operator
* Output of i18n messages without proper escaping
* Output of i18n messages with overt escaping (parsing + html escaping)
* No explicit call of output function of Message class
Comment 1 Amir E. Aharoni 2012-05-18 10:11:26 UTC 
Partial fix for simple issues in https://gerrit.wikimedia.org/r/#/c/7938/ .
Comment 2 Amir E. Aharoni 2012-05-20 21:46:45 UTC 
More fixes in

* https://gerrit.wikimedia.org/r/#/c/8033/
* https://gerrit.wikimedia.org/r/#/c/8121/
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links