Last modified: 2013-07-10 17:31:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38914, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36914 - Special:UploadCampaigns and Special:UploadCampaign contents are hidden from people without editing rights
Special:UploadCampaigns and Special:UploadCampaign contents are hidden from p...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nischay Nahata
https://commons.wikimedia.org/wiki/Sp...
:
: 38341 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-16 20:28 UTC by Brion Vibber
Modified: 2013-07-10 17:31 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2012-05-16 20:28:59 UTC
Campaign info should still be visible even if you don't have editing rights for them. This makes it hard to find the campaign info for Wiki Loves Monuments stuff at the moment...
Comment 1 Brion Vibber 2012-05-16 22:19:39 UTC
Note bug 36915 for adding an API method for fetching this data; that'll help for our WLM app but it'd still be nice to make things visible for regular people.
Comment 2 Pikne 2012-07-31 14:37:04 UTC
*** Bug 38341 has been marked as a duplicate of this bug. ***
Comment 3 Nischay Nahata 2013-03-19 19:01:25 UTC
https://gerrit.wikimedia.org/r/54702
Comment 4 Nischay Nahata 2013-06-21 08:28:38 UTC
Merged.
Comment 5 Tomasz W. Kozlowski 2013-06-22 19:46:11 UTC
This does not seem to work too well:

* [1A] If you're in the 'administrator' or 'UploadWizard campaign editor' user group, log out of Commons;
* [1B] If you're not in either of these groups, just go ahead...
* [2] Go to <https://commons.wikimedia.org/wiki/Special:UploadCampaign/wlm-de-nrw>;
* [3] Hit a permission error.
Comment 6 Alex Monk 2013-06-22 20:08:49 UTC
To be fair the summary did say Special:UploadCampaigns, but it should include Special:UploadCampaign as well...
Comment 7 Gerrit Notification Bot 2013-06-22 21:55:57 UTC
Related URL: https://gerrit.wikimedia.org/r/70027 (Gerrit Change I1f65a4bb6eadc0696b8aa8c3b4e8972b299b8db8)
Comment 8 Nischay Nahata 2013-06-22 21:59:58 UTC
I have submitted a change but there are problems to resolve.

The change causes the form to be displayed to all users with all attributes disabled and no submit/cancel button (I guess that was expected?)

However, this could lead into confusion for some users if we don't display the 'You don't have permissions' warning, which we can't display simultaneously by use of Exceptions. So maybe try another way to display this?
Comment 9 Alex Monk 2013-06-22 22:38:26 UTC
I would like to change the "You are modifying an Upload Wizard campaign." text to "You are viewing an Upload Wizard campaign but you cannot modify it.", however the message key is enforced by FormSpecialPage::getForm to effectively be:
strlower( $this->getName() ) . '-text'.

I think we'll have to do this:

$wgHooks['SpecialUploadCampaignBeforeFormDisplay'][] = function ( &$form ) {
    $form->setHeaderText( wfMessage( 'uploadcampaign-text-readonly' )->parseAsBlock() );
    return true;
};
Comment 10 Alex Monk 2013-06-22 22:40:45 UTC
Um, with a permissions check in there as well of course.
Comment 11 Nischay Nahata 2013-06-23 06:43:23 UTC
I never saw "You are modifying an Upload Wizard campaign." It should definitely be outside the fieldset and also bold. Bad design
Comment 12 Nischay Nahata 2013-06-23 07:26:05 UTC
Using preText() now, looks much more sane
Comment 13 Gerrit Notification Bot 2013-07-10 17:15:37 UTC
Change 70027 abandoned by Yuvipanda:
Show a disabled form for users without permissions.

Reason:
Campaign: namespace has been merged now, and users can see the campaigns without restriction now.

https://gerrit.wikimedia.org/r/70027
Comment 14 Yuvi Panda 2013-07-10 17:31:16 UTC
With the new 'Campaign:' namespace, anyone can view them.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links