Last modified: 2012-05-22 20:42:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38949, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36949 - Openlayers maps and markers are not displayed
Openlayers maps and markers are not displayed
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Maps (Other open bugs)
master
All All
: Unprioritized blocker (vote)
: ---
Assigned To: Jeroen De Dauw
https://translatewiki.net/wiki/User:S...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-18 08:00 UTC by Siebrand Mazeland
Modified: 2012-05-22 20:42 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Siebrand Mazeland 2012-05-18 08:00:56 UTC
We've been using syntax as below for a long while at translatewiki.net. With the current code, maps and markers no longer display. Instead a grey are is displayed with the localised text "Loading map...".

This broke recently.

{{#display_point:52.092397, 5.057801|
service=openlayers|
height=250|
width=215}}

We've been experiencing a lot of breakage in Maps related functionality in the past few weeks. Can I suggest to implement some automated testing to improve stability?
Comment 1 Jeroen De Dauw 2012-05-18 13:02:41 UTC
I noticed this on twn as well. Not sure why it's breaking, works locally. I put a breakpoint in the map JS, and it did not get hit on twn, so something is wrong with the script loading or init script.

> Can I suggest to implement some automated testing to improve
stability?

+1. Not sure I can convince the contributors to convince their clients to have them write tests though :/
Comment 2 Jeroen De Dauw 2012-05-18 13:04:12 UTC
Example broken map on twn using #ask: https://translatewiki.net/wiki/Portal:Nl
Comment 3 Jeroen De Dauw 2012-05-18 13:21:39 UTC
Debugged this a bit but could not find the issue.

Did notice a difference between RL debug on and off. When on, I'm getting this network error in firebug:

"NetworkError: 404 Not Found - http://localhost/phase3/index.php/Theme/default/style.css"

Apparently the code in ext.maps.openlayers.js does not set the path correctly when it's off?

Map does display in both situations though, so was not able to reproduce.
Comment 4 Siebrand Mazeland 2012-05-18 13:47:42 UTC
I'm also getting this error in firebug[1]:

egMapsScriptPath is not defined
http://translatewiki.net/w/extensions/Maps/includes/services/OpenLayers/ext.maps.openlayers.js
Line 13

[1] http://translatewiki.net/wiki/Portal:Nl?debug=true
Comment 5 Mark A. Hershberger 2012-05-18 13:53:09 UTC
(mis-air collision!)

Like Siebrand: Got this with ?debug=true

egMapsScriptPath is not defined
https://translatewiki.net/w/extensions/Maps/includes/services/OpenLayers/ext.maps.openlayers.js
Line 13

Also got a weird one:

"NetworkError: 404 Not Found - https://translatewiki.net/wiki/Undefined/firebug.html"
Comment 6 Mark A. Hershberger 2012-05-18 13:56:15 UTC
ok, weird that I got the same thing without ?debug=true in Chromium -- even the firebug.html
Comment 7 Jeroen De Dauw 2012-05-18 14:08:26 UTC
Ohhh... it should be using mw.config.get /facepalm

That explains the difference, you probably have legacy globals turns off. I should do the same I guess, so I noticed the stuff... 

Change is at Gerrit change #7954
Comment 8 dvdgmz 2012-05-22 08:48:24 UTC
Hi, I've a similar problem.
In a wiki I admin a query with openlayers give also a grey square with "loading map...":
http://lletra.uoc.edu/viquilletra/Usuari:Dvdgmz/test/maps/openlayers

I replaced
includes/libs/JavaScriptMinifier.php 
with 
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=includes/libs/JavaScriptMinifier.php

But that didn't solve the problem.
Comment 9 Jeroen De Dauw 2012-05-22 20:42:46 UTC
That issue is unrelated to this bug report. Replacing that file is what I'd suggest doing, if that did not work, then I don't know how to fix your problem other then upgrading MediaWiki.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links