Last modified: 2014-07-24 04:43:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38964, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 36964 - Incorrect links to "previous 200" page in category listing
Incorrect links to "previous 200" page in category listing
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Categories (Other open bugs)
1.20.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-18 20:34 UTC by Ankry
Modified: 2014-07-24 04:43 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ankry 2012-05-18 20:34:54 UTC
When browsing a category with over 400 pages backwards (from "next" page to "previous") incorrect link to previous page appears. In effect some pages are ommited inlistings.

Testcase:

* Open http://test.wikipedia.org/w/index.php?title=Category:Category_with_many_files and click "next 200" twice (on this and next page)

* When you see pages: Page401 to Page600, click "previous 200"

* You see a page with links to Page201 to Page400, and link to "previous 200" on that page is incorrect: it points to http://test.wikipedia.org/w/index.php?title=Category:Category_with_many_files&pageuntil=Page200#mw-pages instead of http://test.wikipedia.org/w/index.php?title=Category:Category_with_many_files&pageuntil=Page201#mw-pages
(pageuntil should should be set to the first element of current page, not the previos one)

* If you click the "previous 200" link, you see links to Page001 to Page199. the Page200 is omitted.

The "pageuntil=" parameter in a link seems to be the source of the problem. This effect appears on pages generated in backward browsing by clicking the "previous 200" link, when the "pageuntil=" parameter is used. On any wiki. A category must contain at least 401 pages to observe this effect.
Comment 1 Rohan Rawat 2014-07-14 05:46:04 UTC
Can't reproduce.
Maybe it's fixed now.
Can someone confirm and close this ?
Comment 2 Ankry 2014-07-14 08:34:39 UTC
(In reply to Rohan Rawat from comment #1)
> Can't reproduce.
> Maybe it's fixed now.
> Can someone confirm and close this ?

Not fixed. I still can reproduce the above example. More detailed description:

1. Open http://test.wikipedia.org/w/index.php?title=Category:Category_with_many_files : you will see page001 - page200 (it is OK)

2. Click "next 200": you will see page201 - page399 (it is still OK)

3. Click "next 200": you will see page401 and few next (it is still OK)

4. Click "previous 200": you will see page201 - page399 (it is still OK, but now the "previous 200" link is broken)

5. Click "previous 200": you will see page001 - page199 (it is *NOT* OK)

Page200 seem to be lost between step 4. and 5.

Link "previous 200" on a page you received via clicking "previous 200" on another page seems to be broken.
Comment 3 Andre Klapper 2014-07-14 10:12:45 UTC
(In reply to Rohan Rawat from comment #1)
> Can't reproduce.
> Maybe it's fixed now.

If you "cannot reproduce" somewhere in some way, please provide your exact steps. Otherwise everybody can just guess if you tested something different.
Comment 4 Gerrit Notification Bot 2014-07-14 14:21:57 UTC
Change 146067 had a related patch set uploaded by Rohan013:
Fix incorrect "previous 200" link in category listings

https://gerrit.wikimedia.org/r/146067
Comment 5 Gerrit Notification Bot 2014-07-24 02:12:34 UTC
Change 146067 merged by jenkins-bot:
Fix off-by-one error in the "previous 200" link in category listings with until=param

https://gerrit.wikimedia.org/r/146067

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links