Last modified: 2012-07-07 14:28:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T38989, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 36989 - [SF] [Patch] 2.4.2; Add two hooks to SF_UploadWindow.php


Summary:	[SF] [Patch] 2.4.2; Add two hooks to SF_UploadWindow.php

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	SemanticForms (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized enhancement (vote)
Target Milestone:	---
Assigned To:	MWJames

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-05-20 14:36 UTC by MWJames
Modified:	2012-07-07 14:28 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch against SF 2.4.2 (3.63 KB, patch) 2012-05-20 14:36 UTC, MWJames	Details
Add an attachment (proposed patch, testcase, etc.)

Description MWJames 2012-05-20 14:36:53 UTC

Created attachment 10630 [details]
Patch against SF 2.4.2

The patch adds two original hooks [1],[2] (available in the standard SpecialUpload.php) to SF_UploadWindow.php. Both hooks have been available since MW 1.9.0

[1] http://www.mediawiki.org/wiki/Manual:Hooks/UploadForm:initial

[2] http://www.mediawiki.org/wiki/Manual:Hooks/UploadForm:BeforeProcessing

Comment 1 Sumana Harihareswara 2012-05-22 13:43:26 UTC

Added keywords.

Comment 2 Yaron Koren 2012-06-21 22:43:11 UTC

Hi James,

Given that you now have Git access, could you submit this code directly to Gerrit, and then I'll just approve it there? If you can't, I can definitely check this in myself.

Comment 3 Yaron Koren 2012-07-06 14:36:21 UTC

Hi James - just following up again.

Comment 4 MWJames 2012-07-06 16:34:39 UTC

Hi Yaron - Sorry for the delay just got a whole bunch of SMW/SRF stuff (JSON export, new printers) to be tested before I can make a move on SF Upload. I hope I can shift some minutes next week to get this done.

Comment 5 MWJames 2012-07-07 14:28:21 UTC

https://gerrit.wikimedia.org/r/#/c/14617/

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links