Last modified: 2014-09-24 01:10:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39063, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37063 - SquidPurgeClient hangs on response from Squid Cache 2.7, or multiple entries in $wgSquidServers
SquidPurgeClient hangs on response from Squid Cache 2.7, or multiple entries ...
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.19
Other Linux
: Low minor (vote)
: Future release
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-23 22:02 UTC by jayhuggins
Modified: 2014-09-24 01:10 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description jayhuggins 2012-05-23 22:02:14 UTC
Squid Cache 2.7 returns a "Connection: close" header which SquidPurgeClient doesn't recognize or recover from appropriately, resulting in a semi-infinite loop in the SquidPurgeClientPool.run() function, loading the CPU until the loop breaks for a timeout.  Besides the loading and slowing page edits, this bug also prevents some of the purge requests in the pool from being sent at all.

Also, SquirPurgeClientPool doesn't handle multiple squids (multiple entries in $wgSquidServers) because the indexing scheme for $readSockets and $writeSockets in SquidPurgeClientPool.run() is flattened by the socket_select function, and only the first server in the $wgSquidServers array actually receives the purge request.  Again, SquidPurgeClientPool.run() enters a semi-infinite loop as a result, loading the CPU and causing page edits to be very slow in their response.
Comment 1 jayhuggins 2012-05-23 22:21:08 UTC
Note: we discovered this bug in MediaWiki 1.16 and verified it is still in the 1.20 code.
Comment 2 Sumana Harihareswara 2012-05-25 03:48:59 UTC
Jay's patch: https://gerrit.wikimedia.org/r/#/c/8783/ . Thanks for the patch, Jay!
Comment 3 Mark A. Hershberger 2012-05-28 17:56:38 UTC
Lowering priority on high priority bugs that have a low severity
Comment 4 Antoine "hashar" Musso (WMF) 2012-07-25 15:13:11 UTC
New change is https://gerrit.wikimedia.org/r/#/c/12243/
Comment 5 Mark A. Hershberger 2012-09-28 16:47:09 UTC
needs more work, won't make it into 1.20.0

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links