Last modified: 2012-07-29 06:28:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39082, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 37082 - Add the result to the log message of the module "mediawiki.api"


Summary:	Add the result to the log message of the module "mediawiki.api"

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	JavaScript (Other open bugs)
Version:	1.20.x
Hardware:	All All

Importance:	Unprioritized enhancement (vote)
Target Milestone:	1.20.0 release
Assigned To:	Krinkle

URL:
Whiteboard:
Keywords:	easy

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-05-24 12:37 UTC by Helder
Modified:	2012-07-29 06:28 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Helder 2012-05-24 12:37:07 UTC

On [1] we have a parameter "result" which is unused:
----
err: function( code, result ) {
        mw.log( 'mw.Api error: ' + code, 'debug' );
},
----

Woudn't be better to append the "result" to the log message? E.g.:
----
err: function( code, result ) {
        mw.log( 'mw.Api error: ' + code + '(' + result + ')', 'debug' );
},
----

[1] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=resources/mediawiki.api/mediawiki.api.js;hb=HEAD#l27

Comment 1 Helder 2012-07-29 01:29:16 UTC

Fixed by Krinkle on gerrit Change I4d842812
(https://gerrit.wikimedia.org/r/#/c/10662/)

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links