Wikimedia Bugzilla is closed!

I think this may be a bug in the arrowSteps jQuery addon, but I have fixed it on our side of things: https://gerrit.wikimedia.org/r/8928

The arrowSteps plug-in is "our side of things" too (it was developed by NeilK for Upload Wizard), it just lives in MediaWiki core.

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=resources/jquery/jquery.arrowSteps.js;h=f9637545dc4fb49317917e8d95d8cf71edbbbf3b;hb=HEAD

I guess I meant "in this repository". I could try to figure out what's happening in the arrowSteps plugin, but I really don't see any modification of height in it....would you rather I dug deeper to find the height modification, or just let this fix stand?

Dig a little deeper; the current fix looks pretty hackish.

I think it's better now! Patch still need review.

This is no longaer an issue. closing.

Since we have closed this, and there don't appear to be any reopens coming down the pipeline, I'll abandon the patchset.

If this gets reopened, hopefully the patchset will still be there....

*cough* Bugs usually don't fix themselves. This one is still quite easily reproducible (Chrome): Just reload https://commons.wikimedia.org/wiki/Special:UploadWizard a few times. Reopening.

Well, I can't reproduce that way. Maybe there's something else funky going on. Are you in debug mode? Anything else unusual?

Nope. Chrome with a new test account to ensure it's not a pref or customization, after a few reloads:

http://imgur.com/tMtGy

Can't repro it in FF though.

OK, let's drill down to the heart of the matter: Which version of Chrome?

I'm on Chromium 18.0.1025.168 (Developer Build 134367 Linux) Ubuntu 12.04.

Maybe this happens over slower connections, but not faster ones? I'm on an ethernet connection, maybe you're on wireless? I'll test that now.

Wireless didn't change things.

Tried reloading several times on Chrome 24.0.1312.57 m but couldn't reproduce.

Tried again today and could easily reproduce, I also identified the problem but don't have a fix yet.

The bug:
var arrowWidth in the arrowSteps plugin is set to different values on reloads because it depends on background images. If the background images are already loaded the value is right, otherwise its wrong and we see the wrong padding.

Related URL: https://gerrit.wikimedia.org/r/64556 (Gerrit Change Ide468a5259dd81bfbd1ca8117b091b4e9cfee7ce)

Trying to fix the plugin directly. Recent refreshes in latest Chrome shows less aberrant behavior.

Change 64556 merged by jenkins-bot:
jquery.arrowSteps: Center arrowheads text

https://gerrit.wikimedia.org/r/64556

(In reply to Nischay Nahata from comment #16)
> Trying to fix the plugin directly. Recent refreshes in latest Chrome shows
> less aberrant behavior.

Less aberrant or totally fixed?

Not working on this anymore. Would be great if someone else could verify and close this bug.

(In reply to Nischay Nahata from comment #19)
> Not working on this anymore.

Resetting assignee very welcome in such cases. :)

Confirmed that this is now fixed in production as of wmf14.