Last modified: 2012-09-14 18:02:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39136, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 37136 - FlaggedRevs: attempt to revert an edit causes crash in RevisionList.php


Summary:	FlaggedRevs: attempt to revert an edit causes crash in RevisionList.php

Status:	RESOLVED WORKSFORME

Product:	MediaWiki
Classification:	Unclassified
Component:	History/Diffs (Other open bugs)
Version:	1.19.0
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-05-27 08:08 UTC by Edward Chernenko
Modified:	2012-09-14 18:02 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Edward Chernenko 2012-05-27 08:08:41 UTC

PHP Fatal error:  Call to a member function getUser() on a non-object in /opt/www/public_html/includes/RevisionList.php on line 281

(latest FlaggedRevs from git is installed)

Comment 1 Aaron Schulz 2012-06-08 19:13:20 UTC

Using 'reject'? I can't reproduce this. What version of MediaWiki core is being used?

Comment 2 Nate Lenart 2012-09-14 18:02:09 UTC

I have reproduced this bug.

On MediaWiki 1.19.2 (installed into /var/www/html), using latest FlaggedRevs from git.

PHP Notice:  Undefined property: RevisionList::$context in /var/www/html/includes/RevisionList.php on line 261
PHP Fatal error:  Call to a member function getUser() on a non-object in /var/www/html/includes/RevisionList.php on line 281

Looking at /var/www/html/includes/RevisionList.php:261, we have:
$this->context = $list->context;
$context is private in /var/www/html/includes/context/ContextSource.php.
Proposed new line:
$this->context = $list->getContext();

Seems to have fixed the issue for me.

(I'm new to BugZilla and I don't know how submit a diff/patch to this conversation or format comments.)

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links