Last modified: 2012-07-22 07:38:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39149, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 37149 - use class="noprint" instead of OutputPage::isPrintable for FlaggedRevs


Summary:	use class="noprint" instead of OutputPage::isPrintable for FlaggedRevs

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	FlaggedRevs (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Matthias Mullie

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-05-27 17:49 UTC by Umherirrender
Modified:	2012-07-22 07:38 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Umherirrender 2012-05-27 17:49:05 UTC

The text wrapped in id=mw-fr-reviewnotice is not shown, when using printable=yes in the url, but it is shown, when using the printer direct from the page. Without printable=yes the browser does not show any navigation parts in the print result, except id=mw-fr-reviewnotice when looking at a unstable page. Maybe some of the OutputPage::isPrintable should change to class="noprint". Thanks.

Comment 1 Aaron Schulz 2012-07-22 02:17:17 UTC

Fixed in https://gerrit.wikimedia.org/r/16240.

This can also be caused by site CSS setting "display: block !important".

Comment 2 Umherirrender 2012-07-22 07:38:15 UTC

At the moment, I am using 
#mw-fr-reviewnotice {
	display: none;
}
in Print.css to hide the box on the print view.

https://de.wikipedia.org/w/index.php?title=MediaWiki:Print.css&diff=103719243&oldid=99498795

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links