Last modified: 2014-10-21 21:51:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39222, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37222 - Table borders are always shown
Table borders are always shown
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
Feature requests (Other open bugs)
unspecified
All All
: Normal enhancement
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-30 14:51 UTC by Erasmo Barresi
Modified: 2014-10-21 21:51 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Erasmo Barresi 2012-05-30 14:51:27 UTC
In the mobile version of Wikimedia projects, cell borders in tables are always shown, even when they should not. For example there are some templates (such as [http://en.wikisource.org/wiki/Template:Header this] and [http://it.wikisource.org/wiki/Template:Citazione this]) in which tables are used to build something's structure: in this cases borders are unaesthetic. Instead, borders should be shown only if they would in the desktop version.
Comment 1 Jon 2012-05-30 19:32:18 UTC
This is due to tables being display block to enable scrolling on the mobile site.

Agreed we should make these more aesthetically pleasing.
Comment 2 Jon 2012-10-26 21:52:12 UTC
Fixed in https://gerrit.wikimedia.org/r/30288
Comment 3 Erasmo Barresi 2012-10-29 13:31:19 UTC
Thanks!
Comment 4 Ed Sanders 2014-06-26 15:02:58 UTC
This appears to have regressed. The current selector for applying borders is just: .content table td [main.less,200]. There are many places where tables are used to provide layout invisibly.
Comment 5 Florian 2014-06-30 15:35:26 UTC
Caused by: Ib3376651b8bbca3fb5b5ff8e3020efc435be0408
(before moving content css from common to content)

See: https://bugzilla.wikimedia.org/show_bug.cgi?id=49959
Comment 6 Jon 2014-10-08 18:58:24 UTC
We recently submitted a change that would hide the borders on tables within tables. I'm not sure if this will help...

Could you override the style on mobile using MediaWiki:Mobile.css ?
Comment 7 Bingle 2014-10-08 19:00:16 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ScJYJdnL
Comment 8 Jon 2014-10-08 19:01:07 UTC
Patch in question that tweaked the styles was https://gerrit.wikimedia.org/r/165120
Comment 9 Jon 2014-10-10 18:08:22 UTC
I need more feedback on this bug guys. Is there a way we can identify which tables should have borders and which shouldn't?

It seems templates should be able to specify their styles using inline styles to override the default table styling. I'm not sure there is anything we can do here.
Comment 10 Erasmo Barresi 2014-10-17 16:07:35 UTC
Simply stated, only the tables that have borders in the desktop version should have them in the mobile version. But maybe this is of no help from a technical point of view.
Comment 11 Jon 2014-10-17 17:15:44 UTC
I need some specific examples of pages that have this problem so I can dig into this more.. can you provide some more details :)
Comment 12 Erasmo Barresi 2014-10-21 16:09:07 UTC
For instance, take a look at https://en.wikisource.org/wiki/Alice%27s_Adventures_in_Wonderland_(1866) . Template:Header uses a table, but not all the borders have to be shown. By the way, other table styles (width, border color, background color) do no work as well.
Comment 13 Jon 2014-10-21 21:51:06 UTC
This looks like an issue with wikisource.

Wikisource has various rules in https://en.wikisource.org/wiki/MediaWiki:Common.css
which are not being loaded in https://en.wikisource.org/wiki/MediaWiki:Mobile.css

You'll need to get the table related rules copied over and tested by an admin there.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links