Last modified: 2014-09-05 05:52:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39229, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37229 - Blog comment form should be protocol-relative
Blog comment form should be protocol-relative
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Blog (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-30 20:13 UTC by Platonides
Modified: 2014-09-05 05:52 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Platonides 2012-05-30 20:13:41 UTC
The comment form of https://blog.wikimedia.org/ has an explicit action of  http://blog.wikimedia.org/wp-comments-post.php
Comment 1 MZMcBride 2013-05-22 06:47:49 UTC
Perhaps it would be better to just force one protocol or the other. I'm not sure supporting both is necessary.
Comment 2 p858snake 2013-05-22 06:54:25 UTC
Is this a issue with our skin, or upstream in wordpress?
Comment 4 Tomasz W. Kozlowski 2013-10-31 20:03:07 UTC
That's http://git.wikimedia.org/blob/wikimedia%2Fcommunications%2FWP-Victor.git/9b57e64c52a961b313edc4f012a08003b049e04f/comments.php -- it uses get_option('siteurl') which has been deprecated[1] while it should be using site_url which is capable of returning HTTPS links[2].

That being said, there have been rumours that the template was supposed to be rewritten from scratch (I think the WMF even hired a Wordpress magician to do that?) and the blog moved somewhere else, so I'm not sure it's worth spending time on it.

In case someone thinks it is, please feel free to use the linked Wordpress documentation below.

== References ==
* [1] https://codex.wordpress.org/Function_Reference/get_option('siteurl')
* [2] https://codex.wordpress.org/Function_Reference/site_url
Comment 5 Gerrit Notification Bot 2014-06-10 04:56:40 UTC
Change 138533 had a related patch set uploaded by Withoutaname:
Convert links to https or protocol-relative

https://gerrit.wikimedia.org/r/138533
Comment 6 Gerrit Notification Bot 2014-09-05 00:54:57 UTC
Change 138533 abandoned by Withoutaname:
Convert links to https or protocol-relative

https://gerrit.wikimedia.org/r/138533
Comment 7 Nemo 2014-09-05 05:52:24 UTC
On https:

<form action="https://wikimediablog.wordpress.com/wp-comments-post.php" method="post" id="commentform" class="comment-form">

On http:

<form action="http://blog.wikimedia.org/wp-comments-post.php" method="post" id="commentform" class="comment-form">


(why different domain?!).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links