Last modified: 2014-02-13 01:07:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39257, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37257 - Saved searches (shared by others) in Bugzilla sidebar are truncated and contain errors
Saved searches (shared by others) in Bugzilla sidebar are truncated and conta...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Bugzilla (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Andre Klapper
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-01 04:10 UTC by Hydriz Scholz
Modified: 2014-02-13 01:07 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Hydriz Scholz 2012-06-01 04:10:18 UTC
The Wikimedia Bugzilla's sidebar is too small, and some text under the "Saved Searches" gets covered by the main body.

3 suggestions:
1. Increase the width of the sidebar, so that its the same size as the normal wiki.
2. Cut down the amount of text used.
3. Get the text to respect the width of the sidebar, and go to a new line if necessary (like MediaWiki does).

Thanks :)
Comment 1 MZMcBride 2012-06-15 15:17:36 UTC
I've changed the bug summary of this bug from "Sidebar is too narrow" to "Saved searches in Bugzilla sidebar are truncated and contain errors".

Currently in the Bugzilla sidebar, there are a number of saved searches. However, (presumably) due to site CSS, they're cut off. For example, "0. Highest priority ‑ Ch" is how the first saved search reads. This probably just needs a width set on one of the HTML elements in the sidebar.

"0. Unprioritiesed, non‑" also contains a typo.

And I have no idea why "0." is being used (twice).
Comment 2 MZMcBride 2012-06-15 18:37:58 UTC
(In reply to comment #1)
> Currently in the Bugzilla sidebar, there are a number of saved searches.
> However, (presumably) due to site CSS, they're cut off. For example, "0.
> Highest priority ‑ Ch" is how the first saved search reads. This probably just
> needs a width set on one of the HTML elements in the sidebar.

Hmm, guess not. I poked at this briefly. This is the problematic code:

<a href="buglist.cgi?cmdtype=dorem&amp;remaction=run&amp;namedcmd=0.%20Highest%20priority%20-%20Check%20daily&amp;sharer_id=11475"
	class="shared"
	title="Shared by Mark A. Hershberger &lt;mah&#64;everybody.org&gt;"
>0.&nbsp;Highest&nbsp;priority&nbsp;&#8209;&nbsp;Check&nbsp;daily
</a>

Non-breaking spaces are being forced for some reason.

Putting an e-mail address in the title attribute seems rather silly as well, but I suppose only logged-in users see these saved searches.
Comment 3 Andre Klapper 2012-10-10 13:33:10 UTC
https://bugzilla.wikimedia.org/userprefs.cgi?tab=saved-searches enables you to choose whether they are displayed or not, however I lack understanding why Mark's saved searches are displayed by default for new users while others aren't.

Mark: Any idea (and time to fix typos)?
Comment 4 Andre Klapper 2013-08-30 21:07:57 UTC
Problem only happens for **shared** saved searches.

Wild guess after reading the code (not tested): 
In template/en/custom/global/search-links.html.tmpl, the line
>[% q.name FILTER html FILTER no_break %]
should become
>[% q.name FILTER html %]
Comment 5 Andre Klapper 2013-08-30 21:55:53 UTC
Assumption was correct. I just tested this on http://boogs.wmflabs.org with two user accounts.
Comment 6 Gerrit Notification Bot 2013-08-30 21:58:35 UTC
Change 82052 had a related patch set uploaded by Aklapper:
Saved searches with longer names shared by others in sidebar did not wrap

https://gerrit.wikimedia.org/r/82052
Comment 7 Gerrit Notification Bot 2013-08-30 23:28:33 UTC
Change 82052 merged by Dzahn:
Saved searches with longer names shared by others in sidebar did not wrap

https://gerrit.wikimedia.org/r/82052
Comment 8 Daniel Zahn 2013-08-30 23:29:53 UTC
merged and deployed live
Comment 9 Andre Klapper 2013-08-31 13:21:41 UTC
and working. Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links