Last modified: 2014-02-12 23:45:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39267, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 37267 - banner.js and banner.css served to non-zero rated mobile users


Summary:	banner.js and banner.css served to non-zero rated mobile users

Status:	RESOLVED WORKSFORME

Product:	MobileFrontend
Classification:	Unclassified
Component:	Feature requests (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized enhancement
Target Milestone:	---
Assigned To:	Patrick Reilly

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2012-06-01 12:48:20 UTC

We are adding to page load unnecessary. preilly says he will look into this.

Comment 1 Jon 2012-09-04 18:53:13 UTC

It would be good to do this as a use case for other extensions wanting to register javascript/css on the mobile site.

Comment 2 Jon 2012-09-14 00:01:08 UTC

The article feedback team had a first stab at a technique that could be exploited for this https://gerrit.wikimedia.org/r/#/c/23576/

Comment 3 Jon 2012-10-23 17:19:29 UTC

The banner code is now much more generic and actually useful for other things - e.g. serving adverts to download apps, fundraising so closing