Last modified: 2014-02-12 23:53:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39328, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37328 - Footer does not show sister project sitename in English
Footer does not show sister project sitename in English
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-04 22:03 UTC by Phil Chang
Modified: 2014-02-12 23:53 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Phil Chang 2012-06-04 22:03:13 UTC
In the English footer, a Wikipedia logo is used. In other languages, the sitename is used, which is localized. With the sister projects, the English version shows the Wikipedia logo in the footer. This should be changed to use the sitename. In other words, English Wikipedia is the only case where the Wikipedia logo should be used, and if that causes a problem with the sister projects in English, we can change the logo to be the sitename.
Comment 1 Arthur Richards 2012-06-04 22:22:19 UTC
This is a result of this code in SkinMobile.php:

$copyrightLogo = is_array( $wgMFCustomLogos ) && isset( $wgMFCustomLogos['copyright'] ) ?
			$wgMFCustomLogos['copyright'] :
			"{$wgExtensionAssetsPath}/MobileFrontend/stylesheets/images/logo-copyright-{$wgLanguageCode}.png";
...
if ( $wgLanguageCode === 'en' ) { //@fixme: de-WMFize
			$license = Html::element( 'img', array(
				'src' => $copyrightLogo,
				'class' => 'license',
				'alt' => "{$footerSitename} ®"
			) );
		} else {
			$license = Html::element( 'div', array( 'class' => 'license' ),
				"{$footerSitename} ™"
			);
		}

Since that logo already exists on commons, we could configure $wgMFCustomLogos['copyright'] to point to the correct logo for enwiki ONLY. Then we could change the code to something like:

if ( $wgMFCustomLogos['copyright'] ) {
                        $license = Html::element( 'img', array(
				'src' => $wgMFCustomLogos['copyright'],
				'class' => 'license',
				'alt' => "{$footerSitename} ®"
			) );
		} else {
			$license = Html::element( 'div', array( 'class' => 'license' ),
				"{$footerSitename} ™"
			);
		}
And get rid of the $copyrightLogo logic. This would de-wmf-ize the whole thing and resolve this problem.
Comment 2 Arthur Richards 2012-06-04 22:29:53 UTC
Actually, the copyright logo that currently appears on english language projects has a ® symbol on it - the logo text I found on commons does not include the ®, but we could upload our version of the logo to commons for this purpose.
Comment 3 Arthur Richards 2012-06-04 23:51:54 UTC
This is resolved in https://gerrit.wikimedia.org/r/#/c/10202/

When this change is deployed, configuration *also* needs to be updated. I wound up not uploading the logo because I don't think we can host a registered trademark on commons. We can still use the version included with the extension, following configuration changes on the cluster as demonstrated in:
https://gerrit.wikimedia.org/r/#/c/10203/2
Comment 4 Arthur Richards 2012-06-05 00:18:00 UTC
Actually, Heather helped get the logo with the registered mark uploaded to commons, so we can just use that instead of the fancy config change I had made. Instead, config change will need to be in InitialiseSettings.php:

'wmfMFCustomLogos' => array(
  'default' => array( ... ),
  'enwiki' => array(
    'site' => 'Wikipedia',
    'logo' => '//upload.wikimedia.org/wikipedia/commons/5/54/Mobile_W_beta_light.png',
    'copyright' => '//upload.wikimedia.org/wikipedia/commons/4/4e/Wikipedia_mark_mobile.png',
  ),
),

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links