Last modified: 2013-11-04 10:49:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39342, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37342 - [SpecialSearch.php] [patch] [hook] to determine default search profile
[SpecialSearch.php] [patch] [hook] to determine default search profile
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.20.x
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-05 10:23 UTC by MWJames
Modified: 2013-11-04 10:49 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MWJames 2012-06-05 10:23:52 UTC
Not really relates to 32970 but rather it extends its purpose that since search profiles can be specified to allow a hook to determine a search profile to be used as default profile as long as no ($request->getVal( 'profile', $profile === null ) user action has taken place.

## SpecialSearch.php

Line 135: 
$profile = $request->getVal( 'profile', $profile );

+ // Determine a search profile where no user interaction has taken place
+ if ( $profile === null ){
+ 	wfRunHooks( 'SpecialSearchDefaultProfile', array( &$profile ) );
+}

We use this hook to make sure that users don't have to switch manually to an already implemented search profile form (https://github.com/mwjames/projects/tree/master/smw-searchprofile)
Comment 1 Andre Klapper 2013-03-15 17:00:12 UTC
Thanks for your patch!
You are welcome to use Developer access
  https://www.mediawiki.org/wiki/Developer_access
to submit this as a Git branch directly into Gerrit:
  https://www.mediawiki.org/wiki/Git/Tutorial
Putting your branch in Git makes it easier to review it quickly.
Thanks again!
Comment 2 MWJames 2013-11-02 03:29:27 UTC
I don't really care any more.
Comment 3 Andre Klapper 2013-11-02 21:25:21 UTC
...which does not make this request invalid.
Comment 4 MWJames 2013-11-03 05:45:10 UTC
Well, in this case someone else can take the initiate and create a new issue, since I don't see this happen in near future nor that some developer is working on it (and I won't get involve any more in posting a patch to the core because of the hostile environment).
Comment 5 Andre Klapper 2013-11-04 07:26:14 UTC
We don't need to create duplicates on purpose.
This is a valid request, hence please leave it open.
Comment 6 MWJames 2013-11-04 07:43:33 UTC
As the originator of this bug I decided that I don't want be part of this and it should be in the interest of the WMF staff to respect my request as a volunteer.

I'm closing this again for good I hope.
Comment 7 Andre Klapper 2013-11-04 09:57:20 UTC
You don't have to be part of this and that is respected. 
However a bug report that you filed is still valid, and your decision whether you want to be furthermore involved in it or not does not make it invalid. Hence please leave this request open, as it is valid and free to anybody to reuse your patch and put it into Gerrit for review. Maintainers of Core are still free to decide to WONTFIX this if they disagree with the request, though.
Comment 8 MWJames 2013-11-04 10:49:05 UTC
I disagree therefore I close this bug again and the lack of respect for my request is becoming an irritation. I made a decision and I ask politely to respect my request as a volunteer and as someone who donates to the WMF.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links