Last modified: 2013-03-13 12:33:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39399, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 37399 - [Lingo] [patch] 0.4 alpha; Replace tool tip display with jquery.tipsy


Summary:	[Lingo] [patch] 0.4 alpha; Replace tool tip display with jquery.tipsy

Status:	RESOLVED INVALID

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Other (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal enhancement (vote)
Target Milestone:	---
Assigned To:	s7eph4n

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-06-07 23:38 UTC by MWJames
Modified:	2013-03-13 12:33 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
php patch (2.49 KB, patch) 2012-06-07 23:38 UTC, MWJames	Details
JS file (750 bytes, application/x-javascript) 2012-06-07 23:38 UTC, MWJames	Details
CSS file (669 bytes, text/css) 2012-06-07 23:39 UTC, MWJames	Details
Add an attachment (proposed patch, testcase, etc.)

Description MWJames 2012-06-07 23:38:07 UTC

Created attachment 10700 [details]
php patch

Based on https://gerrit.wikimedia.org/r/#/c/9276/

A small patch that uses jquery.tipsy instead.

Comment 1 MWJames 2012-06-07 23:38:44 UTC

Created attachment 10701 [details]
JS file

Comment 2 MWJames 2012-06-07 23:39:13 UTC

Created attachment 10702 [details]
CSS file

Comment 3 MWJames 2012-06-07 23:42:27 UTC

CSS/JS go into folder /resources/

Comment 4 Andre Klapper 2013-03-13 11:56:56 UTC

f.trott: ping - do you plan to review the patch?

Comment 5 MWJames 2013-03-13 12:17:34 UTC

Wow ... already forgot about this one ...

The question would be if jquery.tipsy is the right tool. For example, when having a small note or sentence it certainly is a neat and clean solution (that was what I first thought when changing the tooltip in SMW but it became apparent that with the need for a more controlled user interaction jquery.tipsy was not the right choice which in the end was the reason SMW is now using qtip2).

If you think jquery.tipsy is worth it, I'll give it a shot and post it into gerrit.

Comment 6 s7eph4n 2013-03-13 12:28:01 UTC

I actually already had a patch for this (https://gerrit.wikimedia.org/r/#/c/10986/), but abandoned it, because tipsy also has its limitations, e.g. when it comes to tooltips near the window borders or in very small windows.

Should we close this bug?

Comment 7 MWJames 2013-03-13 12:33:25 UTC

In this case we retire ...

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links