Last modified: 2013-09-18 15:30:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T39416, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 37416 - IPv6 address handling broken
IPv6 address handling broken
Status: RESOLVED FIXED
Product: Huggle
Classification: Unclassified
Application (Other open bugs)
unspecified
All All
: Highest blocker
: ---
Assigned To: Peter Bena
: ipv6
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-08 20:56 UTC by Alex Monk
Modified: 2013-09-18 15:30 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Alex Monk 2012-06-08 20:56:17 UTC
When you select a revision by an IPv6 address, Huggle only thinks that the last part of it is the user name. Thus the user box is filled incorrectly, warning pages are created for non-existent users, and the mouseover (HTML terminology but I don't know what it's supposed to be for VB.NET) revision text is also broken.
Comment 1 Jasper Deng 2012-06-08 20:57:02 UTC
I think this would be an easy fix, regex-wise. Just split from the beginning, not the end.
Comment 2 Alex Monk 2012-07-07 22:37:02 UTC
Is anyone actually fixing this?
Comment 3 matanya 2012-07-24 12:54:06 UTC
seems like the answer is no. anyone?
Comment 4 Jasper Deng 2012-07-24 16:09:10 UTC
I'm going to poke Petrb on his talk page about this.
Comment 5 Peter Bena 2012-07-26 14:25:11 UTC
Hi, if no one is actually going to fix this I can try to do that, but I have no idea how long would it take. Looks like a simple patch, but I will need to recover my virtual box, because huggle 2x is not written in c# (which is only .net IDE I have right now)

Is there any work around for this?
Comment 6 Peter Bena 2012-10-08 14:12:45 UTC
okay, the box I were using for huggle 2x deving is definitely broken and I have no windows machine to install VB to and fix this right now. However I can assist anyone with writing the patch.
Comment 7 Andre Klapper 2012-10-23 18:19:33 UTC
Peter: As this report was set to Highest priority and blocker severity: Do you see this problem as the highest priority for Huggle currently? If not I'd decrease priority, as "Highest" priority should be reserved for bugs that someone needs to drop what they're doing and address really soon (2 or 3 days).
Comment 8 Alex Monk 2012-10-23 19:06:43 UTC
So for me, commenting out this line in User.vb seems to have fixed it:
Name = Name.Substring(Name.LastIndexOf(":") + 1)

I have no idea why this line is here at all, but I presume it's for something important. I also haven't tested it with any write operations - only browsing around edits made by IPv6 users.
Comment 9 Peter Bena 2012-10-24 15:44:45 UTC
Krenair, this make

Name = "User:Jimbo"

Name = Name.Substring(Name.LastIndexOf(":") + 1)

Name == "Jimbo"

That's why it's there, basically changing the line to

Name = Name.Substring(Name.IndexOf(":") + 1)

would fix it. If you can compile the source code, it would be great to put it to download page (I can give you access to download repository)
Comment 10 Peter Bena 2012-10-24 15:47:22 UTC
@Andre, I don't know if this bug should be considered "highest" but it's for sure the number #1 critical bug we have for huggle from all bugs :) and the fact that it wasn't fixed within 2 days, doesn't mean it wasn't supposed to be fixed within 2 days...
Comment 11 Peter Bena 2013-01-17 15:19:05 UTC
fixed
Comment 12 Andre Klapper 2013-01-17 16:37:03 UTC
Thanks a lot, Peter!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links